fix(photo-addon): use 24-hour time format in lightbox#341
Open
paul43210 wants to merge 5 commits intoowncloud:mainfrom
Open
fix(photo-addon): use 24-hour time format in lightbox#341paul43210 wants to merge 5 commits intoowncloud:mainfrom
paul43210 wants to merge 5 commits intoowncloud:mainfrom
Conversation
paul43210
force-pushed
the
feat-photo-addon-24h-time
branch
from
b8c1d9e to
1fce209
Compare
Use hour12: false in toLocaleDateString() so the "Date Taken" field in the lightbox shows 14:30 instead of 2:30 PM. AM/PM notation is US-centric and confusing for international users. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Several date formatting calls in PhotosView and usePhotos were using browser default locale (undefined) instead of the oCIS user's preferred language. Now consistently uses getUserLocale() from useTranslations for timeline group labels (week ranges, month names, full dates). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove hardcoded hour12: false from formatExifDate — the oCIS user locale already determines the appropriate time format (e.g., en-US uses 12h, de uses 24h). Addresses Lukas's review on owncloud#342. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
paul43210
force-pushed
the
feat-photo-addon-24h-time
branch
from
e090b92 to
936c54f
Compare
Contributor
|
Findings after testing:
Note that I did a browser force reload after changing the locale on the photo page. DE: EN: |
toLocaleDateString handles time options (hour, minute) inconsistently across browsers — in EN locale it showed "13:56 PM" instead of "1:56 PM". Switch to toLocaleString which correctly handles both date and time formatting per the oCIS user locale. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
Thanks for testing Martin! This latest push fixes a bug where Regarding the time values in your screenshots — 12:56 on a 24-hour clock (DE) is the same as 12:56 PM on a 12-hour clock (EN), so both are actually showing the correct time. Were you perhaps looking at different photos when comparing, or could there be a timezone difference involved? The expected |
The tooltip previously implied the filter checked for any EXIF metadata (camera, model, location, etc.), but it actually filters by EXIF date (takenDateTime). Updated tooltip to accurately describe the behavior and explain that EXIF date is required for timeline placement, just as EXIF location is required for map view. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hour12: falseintoLocaleDateString()for the "Date Taken" field in the photo lightbox14:30instead of2:30 PM— AM/PM is US-centric and confusing for international usersPhotoLightbox.vueformatExifDate()Test plan
🤖 Generated with Claude Code