Repository navigation
Alert list class search - #3393
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
charliepark
reviewed
Oct 13, 2026
Contributor
Contributor
Contributor
Author
you know, forms should do this by default! it turns out it doesn't work here because the Combobox component is swallowing up the event when it shouldn't. it's a bit of an adjustment to general behavior to "fix", so i think i'll do it as a separate PR |
charliepark
approved these changes
Oct 19, 2026
This is a little fraught: alert list class filtering requires an exact match to a known schema, so we need to do a lot of client-side validation. On the bright side, we now have a lot of client-side validation!
fakemonster
force-pushed
the
alert-list-class-search
branch
from
October 19, 2026 22:16
7a843d0 to
ed14fc7
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



This is a little fraught: alert list class filtering requires an exact match to a known schema, so we need to do a lot of client-side validation. On the bright side, we now have a lot of client-side validation!
alert-class-filtering.mp4