Skip to content

Alert list class search - #3393

Merged
fakemonster merged 6 commits into
mainfrom
alert-list-class-search
Oct 19, 2026
Merged

fakemonster merged 6 commits into
mainfrom
alert-list-class-search

Conversation

@fakemonster

Copy link
Copy Markdown
Contributor

This is a little fraught: alert list class filtering requires an exact match to a known schema, so we need to do a lot of client-side validation. On the bright side, we now have a lot of client-side validation!

alert-class-filtering.mp4

@vercel

vercel Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
console Ready Ready Preview Oct 19, 2026 10:32pm UTC

Request Review

Comment thread app/pages/system/alerting/AlertsTab.tsx Outdated
@charliepark

Copy link
Copy Markdown
Contributor
Screenshot 2026-10-13 at 5 04 59 PM

Not a blocker, but it'd be cool if hitting enter — when there's a "Matches N alert classes" in play — submitted the form. As it is, I need to tab off of the input to submit it.

@charliepark

Copy link
Copy Markdown
Contributor

Small thing here, but I think we'll want to match the gap between the button and the empty container below it from the Receivers tab:
Screenshot 2026-10-13 at 5 14 23 PM
… note how the gap here is a bit wider? I think we want mb-2 instead of mb-4
Screenshot 2026-10-13 at 5 14 16 PM

@fakemonster

Copy link
Copy Markdown
Contributor Author

it'd be cool if hitting enter — when there's a "Matches N alert classes" in play — submitted the form.

you know, forms should do this by default! it turns out it doesn't work here because the Combobox component is swallowing up the event when it shouldn't. it's a bit of an adjustment to general behavior to "fix", so i think i'll do it as a separate PR

This is a little fraught: alert list class filtering requires an exact
match to a known schema, so we need to do a lot of client-side
validation. On the bright side, we now have a lot of client-side
validation!
@fakemonster
fakemonster force-pushed the alert-list-class-search branch from 7a843d0 to ed14fc7 Compare October 19, 2026 22:16
@fakemonster
fakemonster enabled auto-merge (squash) October 19, 2026 22:35
@fakemonster
fakemonster merged commit d84d710 into main Oct 19, 2026
9 checks passed
@fakemonster
fakemonster deleted the alert-list-class-search branch October 19, 2026 22:43

This branch was successfully deployed

1 active deployment
Preview — a420da71 Deployed Oct 19, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants