Skip to content

🎨 Palette: [UX improvement] Add aria-label to follow-up textarea #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
parvezk wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −0
Open

🎨 Palette: [UX improvement] Add aria-label to follow-up textarea #49

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .jules/palette.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
## 2024-05-18 - Fix Session Drawer Linting & Accessibility
**Learning:** When migrating a setState from `useEffect` to the render phase for optimistic updates, it's easy to forget to add the `aria-label` to form fields if they just have placeholders. Placeholders are not a substitute for `aria-label` or `id`/`htmlFor` for screen readers.
**Action:** Always check form elements for `aria-label` or `id`/`htmlFor` when reviewing Next.js/React code.
1 change: 1 addition & 0 deletions web/components/session-drawer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,6 +109,7 @@ export function SessionDrawer({
value={message}
onChange={(e) => setMessage(e.target.value)}
placeholder="Send a follow-up to steer the agent…"
aria-label="Follow-up message"
className="min-h-20 border-zinc-800 bg-zinc-900"
/>
<Button
Expand Down