Keep a resolver out of the egress shape tests - #201
Merged
Merged
Conversation
These cases time out under a slow resolver, which is what a CI runner sometimes has. The guard screens a hostname by resolving it, and the destinations here are either literal IPs — which never reach a resolver — or names that do not exist, so a live lookup adds a network round trip to every case and decides none of them. With DNS screening off the guard builds no resolver at all, and the hostname and address rules these tests are about still apply. What the screen does with an address it resolves is `egress-dns.test.ts`, which builds the guard directly and injects the addresses it is asking about. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Clear test update adds context comments to disable DNS resolver. 🎯 Quality: 91% Elite · 📦 Size: Small 📈 This month: Your 155th PR — above team average · Averaging Excellent |
Contributor
Author
|
/review |
daniloradovic
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These rule-shape tests verify hostname and literal-address matching without DNS-derived evidence. Their helper disables DNS screening, making the cases deterministic and preventing resolver access. DNS-derived behavior remains covered separately with explicitly supplied addresses.