Skip to content

Keep a resolver out of the egress shape tests #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patchstackdave merged 1 commit into from
Sep 2, 2026
Merged

Keep a resolver out of the egress shape tests #201

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion tests/protect/rule-shapes.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,21 @@ describe('when the destination is the only chokepoint', () => {
const entry = { id: `shape:${ID}`, title: s.title, category: s.category, phase: s.phase, rule_v2: s.rule_v2 };
const original = globalThis.fetch;
globalThis.fetch = (async () => new Response('stub')) as any;
const p: any = await createProtection({ rules: { firewall: [entry] }, mode: 'block', egress: true, ...opts });
const p: any = await createProtection({
rules: { firewall: [entry] },
mode: 'block',
egress: true,
// No resolver, so nothing here waits on one. The guard screens a hostname by resolving it, and
// these destinations are either literal IPs — which never reach a resolver — or names that do not
// exist, so a live lookup adds a round trip to every case and decides none of them. With this off
// the guard builds no resolver at all, and the hostname and address rules these tests are about
// still apply.
//
// What the screen does with an address it resolves is `egress-dns.test.ts`, which builds the guard
// directly and injects the addresses it is asking about.
screenDns: false,
...opts,
});
try {
await fn(globalThis.fetch);
} finally {
Expand Down
Loading