chore(Star Icons): Replace all star FA icons with RH brand star icons

[tlabaj]

What: towards #12244

Summary

Replaces PatternFly star-icon / outlined-star-icon usage with Red Hat UI star icons where favorites and sortable-favorites rely on those components.

What changed

• packages/react-core/src/components/Button/Button.tsx

  • Favorite button (not favorited): OutlinedStarIcon → RhUiStarIcon (rh-ui-star-icon)
  • Favorite button (favorited): StarIcon → RhUiStarFillIcon (rh-ui-star-fill-icon)

• packages/react-table/src/components/Table/utils/decorators/sortable.tsx

  • sortableFavorites column label: StarIcon → RhUiStarFillIcon

Summary by CodeRabbit

• Style Updates
  • Updated star icon styling used for favorite state indicators in buttons and table sorting controls.

[coderabbitai]

Walkthrough

Updates star icon usage from PatternFly icons to RH Brand icons across Button and Table sortable components. Adds OutlinedStarIcon mapping to 'rh-ui-star' and updates StarIcon mapping to 'rh-ui-star-fill' in icon registry, with corresponding component implementation changes.

Changes

Cohort / File(s)	Summary
Icon Registry Updates packages/react-icons/scripts/icons/pfToRhIcons.mjs	Added OutlinedStarIcon mapping to 'rh-ui-star' and updated StarIcon mapping from 'rh-ui-star' to 'rh-ui-star-fill'.
Component Icon Usage packages/react-core/src/components/Button/Button.tsx, packages/react-table/src/components/Table/utils/decorators/sortable.tsx	Replaced PatternFly star icons with RH Brand equivalents; Button now uses RhUiStarIcon and RhUiStarFillIcon for unfavorited/favorited states, and sortable utility uses RhUiStarFillIcon for favorite indicator.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related issues

• Update icons in to RH brand icons [react] #12244 — This PR directly implements icon updates to RH Brand icons for the Button component's favorite state and Table sortable utilities, addressing the initiative to replace PatternFly icons with RH Brand equivalents.

Possibly related PRs

• feat(icons): add swap support for mapped rh-ui icons #12245 — Both PRs update icon mappings in pfToRhIcons and switch component imports to RH UI star icons.
• feat(react-icons): add newest rh brand icons #12222 — Both PRs introduce and map rh-ui icons in the react-icons package infrastructure.

Suggested reviewers

• thatblindgeye
• kmcfaul
• mcoker

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main change: replacing PatternFly star icons with Red Hat brand star icons across the codebase, which is the core focus of all three modified files.
Linked Issues check	✅ Passed	The PR addresses the linked issue #12244 by replacing non-RH-brand star icons with RH Brand icons in the Button and Table components, fulfilling the stated objective to update rogue icons.
Out of Scope Changes check	✅ Passed	All changes are directly scoped to replacing star icons with RH brand equivalents; no unrelated modifications to other icon types or components are present.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[patternfly-build]

Preview: https://pf-react-pr-12371.surge.sh

A11y report: https://pf-react-pr-12371-a11y.surge.sh