Skip to content

chore(Star Icons): Replace all star FA icons with RH brand star icons #12371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tlabaj wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −7
Open

chore(Star Icons): Replace all star FA icons with RH brand star icons #12371

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/react-core/src/components/Button/Button.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ import { css } from '@patternfly/react-styles';
import { Spinner, spinnerSize } from '../Spinner';
import { useOUIAProps, OUIAProps } from '../../helpers/OUIA/ouia';
import { Badge } from '../Badge';
import StarIcon from '@patternfly/react-icons/dist/esm/icons/star-icon';
import OutlinedStarIcon from '@patternfly/react-icons/dist/esm/icons/outlined-star-icon';
import RhUiStarFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-star-fill-icon';
import RhUiStarIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-star-icon';
import RhUiSettingsFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-settings-fill-icon';
import { hamburgerIcon } from './hamburgerIcon';

Expand Down Expand Up @@ -211,10 +211,10 @@ const ButtonBase: React.FunctionComponent<ButtonProps> = ({
iconContent = (
<>
<span className={css('pf-v6-c-button__icon-favorite')}>
<OutlinedStarIcon />
<RhUiStarIcon />
</span>
<span className={css('pf-v6-c-button__icon-favorited')}>
<StarIcon />
<RhUiStarFillIcon />
</span>
</>
);
Expand Down
3 changes: 2 additions & 1 deletion packages/react-icons/scripts/icons/pfToRhIcons.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ export const pfToRhIcons = {
OutlinedCommentsIcon: { name: 'rh-ui-comments', icon: getIconData('rh-ui-comments') },
OutlinedHddIcon: { name: 'rh-ui-hard-drive', icon: getIconData('rh-ui-hard-drive') },
OutlinedQuestionCircleIcon: { name: 'rh-ui-question-mark-circle', icon: getIconData('rh-ui-question-mark-circle') },
OutlinedStarIcon: { name: 'rh-ui-star', icon: getIconData('rh-ui-star') },
OutlinedWindowRestoreIcon: { name: 'rh-ui-restore-window', icon: getIconData('rh-ui-restore-window') },
PackageIcon: { name: 'rh-ui-package', icon: getIconData('rh-ui-package') },
PauseCircleIcon: { name: 'rh-ui-pause-circle', icon: getIconData('rh-ui-pause-circle') },
Expand Down Expand Up @@ -151,7 +152,7 @@ export const pfToRhIcons = {
icon: getIconData('rh-ui-sort-down-small-to-large')
},
SortAmountDownIcon: { name: 'rh-ui-sort-down-large-to-small', icon: getIconData('rh-ui-sort-down-large-to-small') },
StarIcon: { name: 'rh-ui-star', icon: getIconData('rh-ui-star') },
StarIcon: { name: 'rh-ui-star-fill', icon: getIconData('rh-ui-star-fill') },
StorageDomainIcon: { name: 'rh-ui-storage-domain', icon: getIconData('rh-ui-storage-domain') },
SyncAltIcon: { name: 'rh-ui-sync', icon: getIconData('rh-ui-sync') },
TableIcon: { name: 'rh-ui-table', icon: getIconData('rh-ui-table') },
Expand Down
4 changes: 2 additions & 2 deletions packages/react-table/src/components/Table/utils/decorators/sortable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,10 @@ import { css } from '@patternfly/react-styles';
import styles from '@patternfly/react-styles/css/components/Table/table';
import { IExtra, IFormatterValueType, ITransform } from '../../TableTypes';
import { SortColumn, SortByDirection } from '../../SortColumn';
import StarIcon from '@patternfly/react-icons/dist/esm/icons/star-icon';
import RhUiStarFillIcon from '@patternfly/react-icons/dist/esm/icons/rh-ui-star-fill-icon';

export const sortableFavorites = (sort: any) => () =>
sortable(<StarIcon />, {
sortable(<RhUiStarFillIcon />, {
columnIndex: sort.columnIndex,
className: styles.tableFavorite,
ariaLabel: sort.ariaLabel ?? 'Sort favorites',
Expand Down
Loading