New split page: close the desktop frame at the top and bottom - #32
Merged
Merged
Conversation
On desktop the /new column ran flush to the viewport's top and bottom edges, so the outline vanished there and the 8px offset shadow started 8px down, leaving a notch at the top-right. The create form has no fixed controls, so it can sit as a card with a 2rem gap above and below; the frame and its form shrink by the same amount so a tall viewport still does not scroll. Opt-in via data-frame="card" so the room screen, whose fixed bottom bar is aligned to the viewport, keeps its full-height column. Mobile is untouched (the rule lives inside the existing min-width: 768px block). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BbTFsJ6NvdFt4NG4UJG57m
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
/chip review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On desktop,
/newran flush to the viewport's top and bottom edges. The frame's outline disappeared at those edges, and the 8px offset shadow started 8px down, leaving a notch at the top-right. Hugo spotted this when clicking through from the landing page.Change
data-frame="card"on the/new<main>.desktop-frame.css(inside the existingmin-width: 768pxblock), that frame getsmargin-block: 2rem. The frame and its form getmin-height: calc(100dvh - 4rem), so a tall viewport still has no scrollbar.Verified by injecting the exact CSS into live
/newwith headless Chrome:🤖 Generated with Claude Code
https://claude.ai/code/session_01BbTFsJ6NvdFt4NG4UJG57m