Skip to content

New split page: close the desktop frame at the top and bottom #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chip-peanut-bot merged 1 commit into from
Sep 30, 2026
Merged

New split page: close the desktop frame at the top and bottom #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/web/src/app/(product-shell)/new/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ export const metadata: Metadata = {
export default async function NewRoomPage({ searchParams }: { searchParams: Promise<Query> }) {
return (
<>
<main className="split-app-frame mx-auto min-h-dvh w-full max-w-xl bg-background">
<main data-frame="card" className="split-app-frame mx-auto min-h-dvh w-full max-w-xl bg-background">
<CreateRoomForm prefill={readPrefill(await searchParams)} />
</main>
{/* The other page a room is created from. It is noindex and no ad points at it, but
Expand Down
12 changes: 12 additions & 0 deletions apps/web/src/styles/desktop-frame.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,18 @@
box-shadow: 8px 8px 0 var(--split-ink);
}

/* A self-contained screen with no fixed controls reads as a card resting on the canvas:
a gap above and below so the outline and offset shadow close on all four sides instead
of running off the viewport. Screens with fixed bars keep the full-height column. */
.split-app-frame[data-frame='card'] {
margin-block: 2rem;
min-height: calc(100dvh - 4rem);
}

.split-app-frame[data-frame='card'] > form {
min-height: calc(100dvh - 4rem);
}

body:has(.split-app-frame) [data-vaul-drawer] {
/* Include both existing 1.5px borders without narrowing the 36rem content. */
width: calc(36rem + 3px);
Expand Down
Loading