fix: Remove default parameters changed in minify-html 0.16.0

[pauloxnet]

Fixes #6, #9

[alexreinking]

That code change looks good to me. From my reading of the minify-html docs, these are now the default. However, I think you need to update the dependency in pyproject.toml:

https://github.com/pelican-plugins/minify/blob/c40fa0106de72ad6023806116b83aa31337d60f2/pyproject.toml#L41C8-L41C27

[pauloxnet]

That code change looks good to me. From my reading of the minify-html docs, these are now the default. However, I think you need to update the dependency in pyproject.toml

Thanks for the review. I updated the PR and set it as ready to be reviewed.

[justinmayer]

Many thanks for this fix, Paolo. Because AutoPub automatically updates the change-log and increments the version number, there is no need to change these manually. Please add a RELEASE.md file to this PR with Release type: patch and containing the description of the changes. (Example)

Also, it seems that CI is reporting test failure(s)/error(s), so that situation should be resolved as well.

[pauloxnet]

Many thanks for this fix, Paolo. Because AutoPub automatically updates the change-log and increments the version number, there is no need to change these manually. Please add a RELEASE.md file to this PR with Release type: patch and containing the description of the changes. (Example)

I forgot every time that your repo are totally automatized :-)

I hope I fixed it properly.

Also, it seems that CI is reporting test failure(s)/error(s), so that situation should be resolved as well.

I try to deep dive in the failures, any help will be appreciated :-D

[justinmayer]

Thanks for the follow-up changes, Paolo. Unfortunately, CI is still reporting test problems. Does the test suite pass for you when you run the tests locally on your workstation?

[pauloxnet]

Unfortunately, CI is still reporting test problems. Does the test suite pass for you when you run the tests locally on your workstation?

It fails also o my machine, but it seems a minify-html issue:
wilsonzlin/minify-html#225

[justinmayer]

The latest comment to the above-linked issue says: “Version 0.17.1 has migrated the JS minifier to oxc, which should be more robust.”

[pauloxnet]

The latest comment to the above-linked issue says: “Version 0.17.1 has migrated the JS minifier to oxc, which should be more robust.”

Thanks for the ping, I tried to update the PR using version 0.17.1 just before shutting down the PC. :)

[pauloxnet]

@justinmayer can you approve the run of the checking workflow?

[Copilot]

Pull Request Overview

This PR updates the plugin to be compatible with the newer version of the minify-html library (0.17.1+) by removing deprecated parameters that were removed from the library's API. It also adds a new contributor to the project.

• Updates minimum minify_html version from 0.10.8 to 0.17.1
• Removes deprecated do_not_minify_doctype and keep_spaces_between_attributes parameters from the minification call
• Adds Paolo Melchiorre as a project author

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File	Description
pyproject.toml	Updates minify_html dependency to version 0.17.1+ and adds new author
pelican/plugins/minify/minify.py	Removes deprecated parameters from minify_html.minify() function call
RELEASE.md	Documents the compatibility fix as a patch release

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[justinmayer]

Excellent work, Paolo. Many thanks for this fix. Much appreciated! 🥇

[pauloxnet]

Excellent work, Paolo. Many thanks for this fix. Much appreciated! 🥇

Thanks for your input and reviews :)