Repository navigation
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5c299ad77e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // mode/preset changes; keep the vendor's dark ink when printing on white. | ||
| @media screen { | ||
| .td-content .markmap { | ||
| --markmap-text-color: var(--bs-body-color); |
There was a problem hiding this comment.
This introduces a public screen/print behavior change, but the commit explicitly says the docsite companion is only an unmerged patch, leaving the canonical EN/ZH Design contract out of sync. Land the corresponding English and Chinese changes under ../oink.pgsty.com/content/docs/design/ together with this implementation rather than leaving them as an external artifact.
AGENTS.md reference: AGENTS.md:L35-L37
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Confirmed: the canonical EN/ZH Design contract update has been added in pgsty/oink.pgsty.com#11, documenting the Markmap screen text, print fallback, and consumer overrides per AGENTS.md. I am leaving this thread open until that companion PR is merged.
1 participant
Fixes #47.
Problem
Markmap labels keep the bundled renderer's
#333text color in dark mode, making even short outlines difficult to read. On the native OINK v1.2.0 Slate canvas, label contrast is approximately 1.50:1.Change
--markmap-text-colorto--bs-body-coloron the article's Markmap wrapper and SVG. The SVG has its own vendor declaration, so setting the token only on an ancestor is insufficient.The labels follow theme changes without rerendering. Vendor code and dependencies are unchanged.
Validation
Previously completed native browser checks cover light/dark presets, saved-mode reload, zoom/collapse, print, and consumer overrides. In the Slate dark comparison above, contrast increases to approximately 16.23:1. Full-site and cross-browser validation remain unverified.