Repository navigation
fix(markmap): follow article text color in screen modes #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| 'use strict'; | ||
|
|
||
| // Source contract only; rendered contrast and interactions belong to the | ||
| // sibling documentation site's Markmap browser suite. | ||
| const assert = require('node:assert/strict'); | ||
| const fs = require('node:fs'); | ||
| const path = require('node:path'); | ||
| const test = require('node:test'); | ||
|
|
||
| const source = fs.readFileSync( | ||
| path.join(__dirname, '../../assets/scss/td/_content-components.scss'), 'utf8', | ||
| ).replace(/\/\*[\s\S]*?\*\/|\/\/[^\n]*/g, ''); | ||
|
|
||
| test('Markmap maps the article token on screen with wrapper/SVG specificity', () => { | ||
| assert.match(source, | ||
| /@media\s+screen\s*\{\s*\.td-content\s+\.markmap\s*\{\s*--markmap-text-color:\s*var\(--bs-body-color\);\s*\}\s*\}/, | ||
| 'keep the mapping screen-only and applicable to both wrapper and SVG'); | ||
| }); | ||
|
|
||
| test('Markmap has no competing text-token assignment or important override', () => { | ||
| const declarations = source.match(/--markmap-text-color\s*:[^;]+;/g) || []; | ||
| assert.deepEqual(declarations, ['--markmap-text-color: var(--bs-body-color);']); | ||
| }); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This introduces a public screen/print behavior change, but the commit explicitly says the docsite companion is only an unmerged patch, leaving the canonical EN/ZH Design contract out of sync. Land the corresponding English and Chinese changes under
../oink.pgsty.com/content/docs/design/together with this implementation rather than leaving them as an external artifact.AGENTS.md reference: AGENTS.md:L35-L37
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed: the canonical EN/ZH Design contract update has been added in pgsty/oink.pgsty.com#11, documenting the Markmap screen text, print fallback, and consumer overrides per AGENTS.md. I am leaving this thread open until that companion PR is merged.