Balance stream error ops on file_put_contents LOCK_EX URL reject - #23186
Merged
Conversation
file_put_contents begins a stream error operation then returns early when LOCK_EX is used with a non-file URL, without ending the operation. After ~1000 such failures the depth limit is exhausted and later stream ops fail. Call php_stream_error_operation_end before that RETURN_FALSE. Closes phpGH-23186
iliaal
force-pushed
the
fix/file-put-contents-lock-ex-depth
branch
from
August 9, 2026 14:33
f61dab6 to
d7c87d2
Compare
bukka
approved these changes
Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
file_put_contents begins a stream error operation then returns early when LOCK_EX is used with a non-file URL without ending the operation. After ~1000 failures the depth limit is exhausted and later stream ops fail. End the operation before that RETURN_FALSE.