Skip to content

Balance stream error ops on file_put_contents LOCK_EX URL reject #23186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iliaal merged 1 commit into from
Aug 9, 2026
+25 −0
Merged

Balance stream error ops on file_put_contents LOCK_EX URL reject #23186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions NEWS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,10 @@ PHP NEWS
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
?? ??? ????, PHP 8.6.0beta1

- Streams:
. Fixed file_put_contents() LOCK_EX early return leaking stream error
operation depth. (iliaal)

- Core:
. Changed run-tests.php to run test subprocesses without a shell where
possible. (NickSdot)
Expand Down
1 change: 1 addition & 0 deletions ext/standard/file.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,6 +474,7 @@ PHP_FUNCTION(file_put_contents)
if (php_memnstr(filename, "://", sizeof("://") - 1, filename + filename_len)) {
if (strncasecmp(filename, "file://", sizeof("file://") - 1)) {
php_error_docref(NULL, E_WARNING, "Exclusive locks may only be set for regular files");
php_stream_error_operation_end(context);
RETURN_FALSE;
}
}
Expand Down
20 changes: 20 additions & 0 deletions ext/standard/tests/file/file_put_contents_lock_ex_url.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
--TEST--
file_put_contents LOCK_EX on non-file URL balances stream error operation
--INI--
allow_url_fopen=1
--FILE--
<?php
for ($i = 0; $i < 1005; $i++) {
@file_put_contents('http://127.0.0.1/x', 'data', LOCK_EX);
}
set_error_handler(function (int $errno, string $errstr): bool {
if (str_contains($errstr, 'Stream error operation depth exceeded')) {
echo "depth_exceeded\n";
}
return true;
});
file_put_contents('http://127.0.0.1/x', 'data', LOCK_EX);
echo "done\n";
?>
--EXPECT--
done
Loading