feat(review-tutor): choose a harness in the tutor page - #80
Merged
Conversation
ElbertePlinio
force-pushed
the
feat/review-tutor-connector-ui
branch
from
August 25, 2026 20:57
f0fbe37 to
af228d0
Compare
Member
Author
|
Ready for human review at b585f01 (stack: #76 → #77 → #78 → #80). Panel: Opus correctness (P2 saved-answer attribution test + P3s → fixed, mutation-verified; P2 adopted-answer attribution deferred to #79 — needs a protocol field), Grok security clean, Sonnet UI/a11y clean. Design acceptance (Fable, design lead): accepted — captures at 1440/860/390 flag on/off, live discovery of Pi + Claude Code + Codex on this machine. Flag stays default-off; local test switch: REVIEW_TUTOR_FLAGS=reviewTutorHarnessConnectors. CI green. |
29 tasks
ElbertePlinio
changed the base branch from
feat/review-tutor-connector-codex
to
main
August 26, 2026 14:14
The Harness select is now populated from discovery, Pi first, and the line under it carries the rest of the truth: how many harnesses are available, or why one is not and that a Pi restart re-discovers. Model and Thinking refill from the selected harness's models, so a model id from another harness can never be submitted. The model chosen per harness and the last harness are remembered in sessionStorage, and the answer header and Learning log entries name the harness and model that produced the answer. /api/state harness entries carry their models so the page never parses a model id. Refs #63
ElbertePlinio
force-pushed
the
feat/review-tutor-connector-ui
branch
from
August 26, 2026 14:17
b585f01 to
5891a85
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
#harnessis populated fromstate.harnesses.filter(available)in registry order (Pi first, then Claude Code, Codex). It stays visible when only one harness is available.#harness-helper, wired througharia-describedby) is the only explanation of the rest:"<n> harnesses available."when everything is available, the joined discovery reasons plus"Restart Pi to re-discover."when something is not, and the pinned"Pi is the only connected harness."with the flag off.#model/#thinkingrefill from the selected harness'smodels. The model chosen per harness is remembered insessionStorage(reviewTutorModelByHarness) and the last harness inreviewTutorHarness, so switching back and reloading restore the selection; an unavailable remembered harness falls back to the default. A model id from another harness can no longer be produced by the page.#answer-attribution) and Learning log entry metadata read<Harness label> · <model label>, resolved by membership so model ids stay opaque to the page. A running answer keeps the identity it started with.GET /api/stateharnesses[]entries carrymodels: ModelChoice[]([]when unavailable). The flatmodelsarray is unchanged for rt/1 compatibility and the server-side membership check.modelId+thinkingLevel, still noharnesskey.Flag stays default-off. No new components, no new tooling.
Tested
npx vitest run packages/review-tutor/test— 344 passed (9 files), including new page tests for population and Pi default, helper strings for all three cases, model/thinking refill and per-harness memory, reload restore and fallback, no cross-harness leakage on ask, running-answer identity, and log attribution;harnesses[].modelspinned intest/server-extension.test.ts.packages/review-tutor && npm run typecheck— clean.bun run check(typecheck, lint, test, coverage, build) — clean.Not tested
pi/claude/codexprocess was run here.QuestionViewcarries no model id, and adding one is outside this contract.Risk class
Serious user-facing.
Refs #63