Repository navigation
CI: Run Validate on merge_group - #678
Merged
Merged
Conversation
Main ruleset requires the `validate` status check. Merge queue builds a gh-readonly-queue branch and emits merge_group, which validate.yml did not listen to, so the check never reported and every queued PR sat in AWAITING_CHECKS until the 1h timeout kicked it out. Signed-off-by: Prasanth Baskar <prasanth@8gears.com> Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The required merge queue trigger is added without changing existing validation logic.
Review effort: Lite
Findings: None
What changed in this PR
Updates the validation workflow to run on GitHub merge queue events, ensuring the required validate check is reported.
Changes:
- Adds the
merge_grouptrigger. - Preserves the existing validation job and context.
| File | Description |
|---|---|
.github/workflows/validate.yml |
Enables validation on merge-group events. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main ruleset requires the
validatestatus check. Merge queue builds agh-readonly-queue/main/*branch and firesmerge_group, whichvalidate.ymlonly listened topull_request. Check never reported on the queue branch, so #665 and #668 sat inAWAITING_CHECKSuntil the 1hcheckResponseTimeoutdropped them.Adds
merge_group:trigger. Job id staysvalidate, matches the required context.git diff origin/main...HEADin the changed-packages step works on the queue branch too.After this lands, #665 and #668 need to be re-queued.
🤖 Generated with Claude Code