Bugfix: console errors on unmount - #88
Conversation
- Use modern dash[testing] version - Change component to use `className` instead of `class` - Change component to use real ref objects rather than invalid string refs
|
Looks good! |
|
Also: |
but it is! 😃 : |
Oh, haha - What's it doing way up there? I always look for it near the |
camdecoster
left a comment
There was a problem hiding this comment.
Looks good except for the few things we discussed.
There was a problem hiding this comment.
As we discussed, this file got regenerated as part of the build process, but it doesn't need to be updated for the bug fix. You could revert this change or update the Dash version in dev requirements to 4.4.1 and update the setup.py Dash version floor. There's also an issue with newer Dash that resulted in the style prop getting dropped from the docstring.
There was a problem hiding this comment.
All done in 7cb037b
I reverted the dev requirements back to v2.18 of Dash just to keep the scope from creeping up here.
We can do the extra work to bump everything else as part of a major version later.
This PR fixes a flood of Javascript errors thrown when the player is unmounted while a video is playing.
While I'm in the neighbourhood:
classNameinstead of invalidclassReact.createRef()for refs instead of hard-coded stringplayerFixes #74
Fixes https://github.com/plotly/ddk-dash-docs/issues/4081