Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 0 additions & 38 deletions .circleci/config.yml

This file was deleted.

47 changes: 47 additions & 0 deletions .github/workflows/ci.yml
Comment thread
KoolADE85 marked this conversation as resolved.
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
name: CI

on:
push:
branches: [master, main]
pull_request:

jobs:
test-and-lint:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2

- name: Set up Node.js
uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
with:
node-version: "22"

- name: Set up Python
uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065 # v5.6.0
with:
python-version: "3.10"

# ubuntu-latest ships Google Chrome and a matching ChromeDriver; expose
# the driver on PATH so selenium (pinned <=4.2.0, no Selenium Manager)
# can find it.
- name: Put ChromeDriver on PATH
run: echo "$CHROMEWEBDRIVER" >> "$GITHUB_PATH"

- name: Install Python dependencies
run: pip install -r requirements-dev.txt

- name: Lint with flake8
run: npm run lint

- name: Build package
run: |
npm install
npm run build

- name: Run tests
run: npm run test -- --headless

- name: Run tests using React 18
run: npm run test -- --headless
env:
REACT_VERSION: 18.2.0
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,13 @@ Changes to `dash-player` were sponsored by Volkswagen's Center of Excellence for

---

## [Unreleased]

## Fixed

- [#74](https://github.com/plotly/dash-player/issues/74) Fixed video player throwing errors on unmount
- Updated dependencies and outdated react syntax to eliminate development environment issues

## [1.1.0] - 2023-03-16

## Changed
Expand Down
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@

We recommend the following versions to build this package:

- `node`: 16.17.0
- `npm`: 8.15.0
- `node`: 22.x
- `npm`: 10.x

To generate builds manually, run the following:

Expand Down
2 changes: 1 addition & 1 deletion dash_player/async-dashplayer.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dash_player/async-dashplayer.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dash_player/dash_player.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dash_player/dash_player.min.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions dash_player/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
"react-dom": ">=17"
},
"engines": {
"node": "^16.17.0",
"npm": "^8.15.0"
"node": ">=22.0.0",
"npm": ">=10.0.0"
}
}
2 changes: 1 addition & 1 deletion inst/deps/async-dashplayer.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion inst/deps/async-dashplayer.js.map

Large diffs are not rendered by default.

Loading
Loading