fix: better error for failed run section #752
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
run section output can be long and it can be a pain to find which image failed to build in multiple-image situations. This just adds the obvious information to the error you see at the end. Signed-off-by: Michael McCracken <mikmccra@cisco.com>
mikemccracken
requested review from
hallyn,
raharper,
rchamarthy,
rchincha,
smoser and
tych0
as code owners
elastic/dockerfiles recently removed the actual dockerfiles from main, so now you have to go to a specific branch to get it Signed-off-by: Michael McCracken <mikmccra@cisco.com>
mikemccracken
force-pushed
the
2026.01.28/main/what-file-failed
branch
from
b5ff43c to
41da9c8
Compare
ref https://docs.docker.com/reference/dockerfile/#workdir "If the WORKDIR doesn't exist, it will be created even if it's not used in any subsequent Dockerfile instruction." Signed-off-by: Michael McCracken <mikmccra@cisco.com>
raharper
reviewed
Jan 29, 2026
Contributor
raharper
left a comment
raharper
left a comment
There was a problem hiding this comment.
Looks like a nice improvement. Thanks for looking at this.
+1 on this after "workflow" is happy and squashed commits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run section output can be long and it can be a pain to find which image failed to build in multiple-image situations.
This just adds the obvious information to the error you see at the end.
now it looks like this:
✅ By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.