Skip to content

fix: better error for failed run section #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mikemccracken wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: better error for failed run section #752

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a34634c
fix: better error for failed run section
mikemccracken Jan 28, 2026
41da9c8
ci: fix convert test for elastic dockerfile
mikemccracken Jan 28, 2026
ac6b265
fix: convert: WORKDIR creates its argument
mikemccracken Jan 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/stacker/build.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,7 +522,7 @@ func (b *Builder) build(s types.Storage, file string) error {
log.Infof("failed executing %s: %s\n", opts.OnRunFailure, err2)
}
}
return errors.Errorf("run commands failed: %s", err)
return errors.Errorf("run commands failed for image %q in %q: %s", name, sf.FilePath(), err)
}
}

Expand Down
1 change: 1 addition & 0 deletions pkg/stacker/convert.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,7 @@ func (c *Converter) convertCommand(cmd *Command) error {
c.env[key] = val
}
case "workdir":
layer.Run = append(layer.Run, fmt.Sprintf("mkdir -p %s", cmd.Value[0]))
layer.Run = append(layer.Run, fmt.Sprintf("cd %s", cmd.Value[0]))
c.currDir = cmd.Value[0]
case "arg":
Expand Down
4 changes: 4 additions & 0 deletions pkg/types/stackerfile.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,10 @@ func (sf *Stackerfile) Get(name string) (Layer, bool) {
return layer, ok
}

func (sf *Stackerfile) FilePath() string {
return sf.path
}

func (sf *Stackerfile) Len() int {
return len(sf.internal)
}
Expand Down
2 changes: 1 addition & 1 deletion test/convert.bats
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ EOF

@test "elasticsearch" {
skip_slow_test
git clone https://github.com/elastic/dockerfiles.git
git clone -b v9.2.4 https://github.com/elastic/dockerfiles.git
chmod -R a+rwx dockerfiles
cd dockerfiles/elasticsearch
stacker convert --docker-file Dockerfile --output-file stacker.yaml --substitute-file stacker-subs.yaml
Expand Down
Loading