fix(core): guard code blocks against leaked native Enter on WebKit - #522
Open
ocavue wants to merge 4 commits into
Open
fix(core): guard code blocks against leaked native Enter on WebKit #522ocavue wants to merge 4 commits into
ocavue wants to merge 4 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reachedNext included review available in 19 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||
commit: |
ocavue
changed the title
noLink units
ocavue
marked this pull request as ready for review
August 30, 2026 16:13
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ocavue
changed the title
noLink units
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prosemirror-view lets some Safari Enter keydowns reach native editing (every plain Enter on iOS, and the first keydown within 500ms after
compositionendon desktop), and WebKit then clone-splits the<pre>, leaving a rogue<br>in the code block or silently deleting the text before the caret. This adds abeforeinputguard that cancelsinsertParagraph/insertLineBreakinside a code block on WebKit and reruns the key through the keymap pipeline. Draft until the iOS side is verified on a real device (cancelingbeforeinputmust not confuse the virtual keyboard).