go executor: restart KeepAlive tasks on clean exit#12
Merged
Conversation
A KeepAlive task that exits with no error and no context cancellation (e.g. an fx service that catches SIGTERM and shuts down gracefully) was treated as "done" and never restarted. This treats it as an error so the existing KeepAlive restart path kicks in. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
KeepAlivetask that exits with no error and no context cancellation (e.g. an fx service that catches SIGTERM and shuts down gracefully with exit code 0) was previously treated as "done" and never restartedKeepAlivefield's doc comment says "this task will be restarted when it exits, regardless of exit code" — this change makes the implementation match that intentContext
Local dev eventsworker (and other fx-based services) occasionally receive external signals, fx catches them and exits cleanly (code 0), and taskrunner doesn't restart because
KeepAliveonly checked fortaskExecutionState_error, nottaskExecutionState_done.Test plan
go test ./...passeskill <pid>, verify it restarts🤖 Generated with Claude Code
Need help on this PR? Tag
@codesmithwith what you need.