Skip to content

go executor: restart KeepAlive tasks on clean exit #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChenJesse merged 1 commit into from
May 6, 2026
Merged

go executor: restart KeepAlive tasks on clean exit #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions executor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -660,6 +660,14 @@ func (e *Executor) runPass() {
simpleEvent: execution.simpleEvent(),
Error: err,
})
} else if task.KeepAlive {
// A KeepAlive task should never exit cleanly on its own —
// treat it as an error so it gets restarted.
execution.state = taskExecutionState_error
e.publishEvent(&TaskFailedEvent{
simpleEvent: execution.simpleEvent(),
Error: fmt.Errorf("keep-alive task %s exited unexpectedly", task.Name),
})
} else {
execution.state = taskExecutionState_done
e.publishEvent(&TaskCompletedEvent{
Expand Down
Loading