Skip to content

[Feature] Add the DreamerV3 block RSSM core - #4072

Draft
vmoens wants to merge 1 commit into
gh/vmoens/289/basefrom
gh/vmoens/289/head
Draft

[Feature] Add the DreamerV3 block RSSM core#4072
vmoens wants to merge 1 commit into
gh/vmoens/289/basefrom
gh/vmoens/289/head

Conversation

@vmoens

@vmoens vmoens commented Aug 8, 2026

Copy link
Copy Markdown
Collaborator

Stack from ghstack (oldest at bottom):

Summary:

  • add the grouped block-linear recurrent core used by DreamerV3
  • add RMS-normalized prior and posterior predictor options
  • preserve the existing GRU implementation as the default for checkpoint compatibility

Rationale:
The maintained DreamerV3 implementation used a conventional GRUCell, while the
reference architecture projects deterministic state, stochastic state, and action
separately before applying grouped recurrent gates. Providing the block core as an
explicit mode enables architecture-parity experiments without invalidating existing
TorchRL models.

Test plan:

  • pytest test/modules/test_dreamer_components.py -k DreamerV3Components -q
  • pytest test/objectives/test_dreamer_v3.py -q
  • verify the frozen numerical fixture, normalized-action invariance, gradients,
    RMS-normalized posterior shapes, and torch.compile full-graph execution

[ghstack-poisoned]
@pytorch-bot

pytorch-bot Bot commented Aug 8, 2026

Copy link
Copy Markdown

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/4072

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 3 Unrelated Failures

As of commit a1dc57e with merge base 2a77e48 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following job failed but was likely due to flakiness present on trunk:

BROKEN TRUNK - The following jobs failed but was present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Feature New feature Integrations/torch_geometric Integrations Modules

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant