[Feature] Complete DreamerV3 continuation training semantics - #4074
[Feature] Complete DreamerV3 continuation training semantics#4074vmoens wants to merge 3 commits into
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/rl/4074
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 049ac18 with merge base d7659c7 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
| outscale=0.0, | ||
| norm_eps=cfg.networks.norm_eps, | ||
| ), | ||
| in_keys=["state", "belief"], |
There was a problem hiding this comment.
@vmoens actor seems to be missing observation?
jax version uses obs + belief + state
|
Update after the stack-level ghstack rebase: The full eight-PR Dreamer stack was checked out from #4075, rebased onto current I attempted the requested rebase of current head I reviewed the existing head and the latest inline comment meanwhile. The cited DreamerV3 implementation feeds the policy |
[ghstack-poisoned]
[ghstack-poisoned]
Stack from ghstack (oldest at bottom):
Summary:
Rationale:
A continuation predictor is only useful when its probabilities govern imagined
returns and objective weighting. Previously the optional auxiliary loss did not
affect imagination, recurrent carries were not explicitly reset at episode
boundaries, and the maintained setup used materially different preprocessing and
optimization settings. These gaps prevented meaningful reference-curve comparison.
Test plan:
terminal target scaling, recurrent resets, symlog inputs, AGC, and zero-scale heads