Skip to content

Expose bounded pocket size lanes without duplicate leaders (#2211) - #2220

Merged
pzfreo merged 2 commits into
fix/2211-envelope-lanefrom
fix/2211-pocket-size-lanes
Oct 7, 2026
Merged

pzfreo merged 2 commits into
fix/2211-envelope-lanefrom
fix/2211-pocket-size-lanes

Conversation

@pzfreo

@pzfreo pzfreo commented Oct 7, 2026 •

Copy link
Copy Markdown
Owner

Addresses the rectangular-pocket width/length lane slice of #2211. Stacked on #2219 in GitHub stack #2229; merge atomically with the stack when every required check is green.

An explicit lane moves only the selected approved pocket size into the shared linear whole-ink solve. The combined pocket leader keeps the remaining approved sizes/depth but no longer repeats the moved size. No-lane pocket output remains the existing combined leader. Infeasible lane placement retains pocket_dim_dropped evidence.

Local checks: 26 pocket-completeness and focused tests; all 7 source-shape tests after refactoring and ratcheting the function-length baseline; Ruff; mypy (196 source files); strict MkDocs; architecture guards; 100% changed production-line coverage on the focused run. The broader #2211 remains open.

@pzfreo
pzfreo force-pushed the fix/2211-pocket-size-lanes branch from a0458d4 to 0bf7878 Compare October 7, 2026 03:51
@pzfreo
pzfreo added this pull request to stack #2229 October 7, 2026 03:52
@pzfreo
pzfreo force-pushed the fix/2211-pocket-size-lanes branch from 0bf7878 to 81a2e9d Compare October 7, 2026 03:57
@pzfreo

pzfreo commented Oct 7, 2026

Copy link
Copy Markdown
Owner Author

CI review: the macOS canary failed only the source-shape baseline guard. When this pocket-lane slice was restacked above #2228, its follow-up commit accidentally reintroduced the old _render_slot_dimensions length ceiling that #2228 had correctly removed. I amended this slice to keep that ceiling removed; the 7 source-shape tests now pass here and on the rebased #2222 child. The final combined tree is byte-identical to the previously tested tip. Fresh checks are running on the corrected heads.

@pzfreo
pzfreo merged commit 9a7fa73 into main Oct 7, 2026
19 checks passed
@pzfreo
pzfreo deleted the fix/2211-pocket-size-lanes branch October 7, 2026 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant