Repository navigation
Expose bounded pocket size lanes without duplicate leaders (#2211) - #2220
Merged
Merged
Conversation
pzfreo
force-pushed
the
fix/2211-pocket-size-lanes
branch
from
October 7, 2026 00:10
49b44a2 to
a0458d4
Compare
pzfreo
force-pushed
the
fix/2211-pocket-size-lanes
branch
from
October 7, 2026 03:51
a0458d4 to
0bf7878
Compare
pzfreo
added this pull request to stack #2229
October 7, 2026 03:52
pzfreo
force-pushed
the
fix/2211-pocket-size-lanes
branch
from
October 7, 2026 03:57
0bf7878 to
81a2e9d
Compare
Owner
Author
|
CI review: the macOS canary failed only the source-shape baseline guard. When this pocket-lane slice was restacked above #2228, its follow-up commit accidentally reintroduced the old _render_slot_dimensions length ceiling that #2228 had correctly removed. I amended this slice to keep that ceiling removed; the 7 source-shape tests now pass here and on the rebased #2222 child. The final combined tree is byte-identical to the previously tested tip. Fresh checks are running on the corrected heads. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the rectangular-pocket width/length lane slice of #2211. Stacked on #2219 in GitHub stack #2229; merge atomically with the stack when every required check is green.
An explicit lane moves only the selected approved pocket size into the shared linear whole-ink solve. The combined pocket leader keeps the remaining approved sizes/depth but no longer repeats the moved size. No-lane pocket output remains the existing combined leader. Infeasible lane placement retains pocket_dim_dropped evidence.
Local checks: 26 pocket-completeness and focused tests; all 7 source-shape tests after refactoring and ratcheting the function-length baseline; Ruff; mypy (196 source files); strict MkDocs; architecture guards; 100% changed production-line coverage on the focused run. The broader #2211 remains open.