Repository navigation
test: play the balance games in beforeAll so pnpm test skips them for real - #172
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pourquoi
pnpm testest passé de quelques secondes à environ 400 s, et le jobcheckde la CI d'une minute à quatre à sept minutes, depuis #166. Le banc d'équilibrage est marquédescribe.skipIf(env.BALANCE === undefined), mais Vitest exécute le corps d'undescribependant la collecte, même sauté : toute la matrice (34 équipes, 20 graines) se jouait à chaquepnpm test, comptée en temps d'import (« import 97 % »).Quoi
Les parties se jouent dans un
beforeAll, qui ne tourne pas quand le bloc est sauté.Preuves
pnpm exec vitest run src/sim/balance.slow.test.tssansBALANCE: 382 s avant, 2 s après.BALANCE=1 BALANCE_QUICK=1 BALANCE_SEED_COUNT=2: le banc joue et écrit son tableau ; avec deux graines seulement, trois cibles échouent, ce qui est le bruit attendu, pas une régression (pnpm balancegarde ses 20 graines).