Add separate tsconfig for webview#3009
Merged
jdneo merged 1 commit intoredhat-developer:masterfrom Mar 20, 2023
Merged
Conversation
Signed-off-by: Shi Chen <chenshi@microsoft.com>
jdneo
approved these changes
Mar 20, 2023
Collaborator
jdneo
left a comment
jdneo
left a comment
There was a problem hiding this comment.
LGTM, it makes sense to sperate the config for different source sets.
gayanper
pushed a commit
to gayanper/vscode-java
that referenced
this pull request
May 27, 2023
Signed-off-by: Shi Chen <chenshi@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR, we have a basic
tsconfig.base.json, two configurationstsconfig.json(for extension) andtsconfig.webview.json(for webview) specifies the source configuration and source directories.will address the side effects from #2967 , which might cause configuration problems related to tsconfig rule
esModuleInterop.