docs: clean up stale rpk command overrides - #1865
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughUpdated Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
✅ Deploy Preview for redpanda-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs-data/rpk-overrides.json`:
- Around line 1089-1102: Restore the generated Usage section in the
rpk-connect-run documentation generation flow, preserving it while removing the
hand-written Flags table. Regenerate the downstream page and ensure the
generated == Usage section appears between the description and == Flags.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: c2d14521-1eb9-4129-8a66-dd14bd6440d9
📒 Files selected for processing (1)
docs-data/rpk-overrides.json
|
This supersedes two of my open cleanups, reconciled as follows:
|
JakeSCahill
left a comment
There was a problem hiding this comment.
Reviewed with ground-truth checks against the committed snapshot, the binary help, and the open regen PRs. The cleanup itself is right — every removal checks out — but there is one sequencing hazard worth deciding deliberately, plus two coordination notes.
Verified correct
rpk ai llmdeletion: your drift argument holds and I withdrew my migration suggestion — the provider-type enumeration now lives in the source help itself (rpk ai llm-provider's description says "Supported provider types: openai, anthropic, google, bedrock" andcreate's description names the config groups includingopenai-compatible), so extraction delivers it without any override. Closing my #1858 in favor of this. One upstream nit worth passing to ADP: the parent command's list omitsopenai-compatiblewhilecreate's includes it — their drift now, not ours.rpk ai llm check→llm-provider checkmigration: correct, and agreed the curated wording is clearer.restore-startandstudio sync-schemadeletions: both paths verified gone from the tree. One question: doesrpk cluster storage restore start's own help cover the--waitpolling behavior the deleted text described? If not, that sentence may be worth carrying to the new path.
Sequencing hazard: the connect run Flags drop
Dropping the curated Flags section is the right end state (the extracted table has 18 flags vs the curated 7), but no committed snapshot carries extracted connect flags yet: rpk-v26.2.1-rc2.json has zero flags on rpk connect run (extraction shipped in 5.3.0, after that snapshot), and #1845 was generated pre-extraction. If this merges before a 5.3.x regeneration lands, any interim regen from the current snapshot renders rpk connect run with no flag documentation at all — and once #1863's overrides-change re-render workflow merges, this PR's own merge would trigger exactly that regen. Suggestion: hold this until the v26.2.1 re-dispatch PR (which will carry the extracted flags) merges, or land the two together.
Coordination notes
- The
rpk container statushunk is byte-identical to #1860's — convergent fixes, which is reassuring. #1860 additionally fixes the currently published page (this PR leaves the double heading live until regen) and carries theapplyToCodetransformation rule the next regen needs. Identical hunks merge cleanly in either order, but consider dropping the hunk here and letting #1860 own it, so the change has one home. - The four new per-flag descriptions restate the binary help that extraction will supply — which is the same drift pattern this cleanup removes elsewhere. If the intent is phrasing control, keeping them is fine (they're consistent with the existing log.level/set/resources precedent); if not, dropping them lets extraction own those descriptions, including the
(default: false)notes the help carries and these replacements drop.
2bf7d44 to
e937261
Compare
Four override entries pointed at command paths that no longer exist, so they silently did nothing and showed up as validation errors on every generator run: - rpk ai llm and rpk ai llm check were renamed to rpk ai llm-provider. Migrate the check description to the new path. Drop the provider-type list, which was already missing openai-compatible and is the kind of enumeration that drifts. - rpk cluster storage restore-start is now rpk cluster storage restore start. Drop the override: the source description is more complete, covering the wait flag, cluster-uuid-override, and a link to the whole-cluster-restore docs, and the page already has an alias from the old name. - rpk connect studio sync-schema is gone entirely, along with the rest of rpk connect studio. Also replace the hand-written Flags table on rpk connect run with per-flag overrides. The table listed 7 flags while the command has 13, so secrets, redpanda-license, disable-telemetry, the two telemetry flags, and rpc-plugins were undocumented. Moving its curated wording into the flags map keeps the descriptions and picks up the missing flags, and restores Usage ahead of Flags on the page. Override validation now reports zero errors, down from four. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
Rebased onto main post-#1868 (clean, all four cleanups intact) per your follow-up note. Sequencing reminder from my review still applies to the connect run Flags drop: no committed snapshot carries extracted connect flags yet, so ideally this merges with or after the next full regeneration. |
e937261 to
e152257
Compare
|
Sequencing requirement found while testing this against the rest of the queue, on my own PR. It does not change the diff, but it does change when this can safely merge. Removing the hand-written Flags table here is correct: #225 made the extracted table authoritative, and the hand-written one was stale (7 flags against the command's 13, missing The committed snapshot has That matters because #1863 re-renders from the committed snapshot on any overrides change, so merging this while that workflow is live would strip the table via an auto-PR. The fix is ordering, not a code change. Once an extraction run persists connect flags into the snapshot, from-json is safe: So this should merge after the v26.2.1 re-dispatch, and the check before merging is that committed Merge order for the four PRs touching this file, all pairwise-tested: #1838, #1860, and this are mutually clean in any order; only #1862 conflicts, with both #1838 and this, in either direction, so it wants rebasing last. |
|
The sequencing requirement above has been independently re-verified in a fresh pass and holds. One correction to the check as I originally wrote it: #1863 resolves the newest snapshot (tilde-normalized sort), so after the v26.2.1 re-dispatch the file to verify is the new |
JakeSCahill
left a comment
There was a problem hiding this comment.
Approving: my earlier review verified every removal against ground truth, and the sequencing hazard I flagged (connect run's Flags table vanishing on a from-json rerender) is now handled by your merge-order plan — this merges after the re-dispatch auto-PR lands the extracted connect flags in the snapshot, and before #1863. Your two refinements (gate on the auto-PR merging, and the newest-snapshot sort selecting rpk-v26.2.1.json post-re-dispatch) are exactly right.
Summary
Cleanup of
docs-data/rpk-overrides.json. Four entries pointed at command paths that no longer exist, so they silently did nothing and surfaced as validation errors on every generator run. One more override duplicated content the generator already produces, giving a page two conflicting Flags tables.Override validation now reports zero errors, down from four.
Stale command paths
rpk ai llm checkrpk ai llm-provider checkrpk ai llmopenai-compatible, and is the kind of enumeration that driftsrpk cluster storage restore-startrpk cluster storage restore start. The source description is more complete, covering--wait/-w,--cluster-uuid-override, and a link to the whole-cluster-restore docs. The page already carries an alias from the old namerpk connect studio sync-schemarpk connect studiois gone from the command tree, with no equivalent and no pages in this repoDuplicate Flags table
rpk connect runcarried both a supportedflags:map and a legacycontentsection hardcoding a full Flags table, so the page rendered two== Flagssections with conflicting content. The hardcoded table was also stale:--secrets,--redpanda-license,--disable-telemetry,--telemetry-deployment-type,--telemetry-tenant-id, and--rpc-pluginswere missing from the published page.Its curated descriptions moved into the
flags:map, so the page keeps the polished wording and picks up the six missing flags. This also restores Usage ahead of Flags, since the removed section was positionedafter_description.Verification
Ran the generator against the committed
v26.2.1-rc2snapshot with a live plugin binary for flag extraction:rpk connect run: one== Flagssection with 13 rows (was 7), all descriptions sentence-capitalized, curated wording intact forlog.level,set, andresources, Usage back ahead of Flagsrpk ai llm-provider checkrenders the migrated descriptionrpk cluster storage restore startrenders the fuller source descriptionNote on scope
An earlier revision of this PR also fixed the duplicate
== Exampleheading onrpk container status. That change is covered by #1860, which makes the identical override edit and additionally fixes the rendered page, so it has been dropped here to avoid a conflict. This PR no longer touches that override.No
.adocfiles change in this PR, so there is nothing to preview. The generated pages update the next time the rpk docs automation runs.