storage: move call to transactional_stm_type() out of noexcept c-tor#30581
Merged
Conversation
…c-tor This function call, `transactional_stm_type()`, used to just check the `_tx_stm` status - however, now it performs a `check_status()` call, which will throw a `gate_closed_exception()` if the `_status` is `status::shutting_down`: f935a80. Because of this change, when this function throws (i.e. during shutdown), the previously truly `noexcept` constructor now causes an abort of the program. Move the call to outside of the `noexcept` constructor to prevent this race from terminating the program.
Because why are we doing this?
WillemKauf
requested review from
andrwng,
bashtanov,
bharathv,
Copilot and
dotnwat
Contributor
There was a problem hiding this comment.
Pull request overview
This PR prevents shutdown-time exceptions from causing a fatal std::terminate() by removing a potentially-throwing stm_hookset::transactional_stm_type() call from a noexcept tx_reducer constructor, and instead computing/passing the value at the call site.
Changes:
- Precompute
transactional_stm_type()inbuild_compaction_index()and pass it intotx_reducer. - Update
tx_reducerto accept the precomputedstd::optional<storage::stm_type>and stop calling intostm_hooksetfrom its constructor.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/v/storage/segment_utils.cc | Computes transactional_stm_type() before constructing tx_reducer, avoiding a throw inside the reducer constructor. |
| src/v/storage/compaction_reducers.h | Updates tx_reducer constructor signature to accept the precomputed transactional STM type and removes the throwing call from the initializer list. |
bharathv
approved these changes
May 21, 2026
Contributor
Author
|
/ci-repeat 1 |
bashtanov
approved these changes
May 22, 2026
Collaborator
|
/backport v26.1.x |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function call,
transactional_stm_type(), used to just check the_tx_stmstatus - however, now it performs acheck_status()call, which will throw agate_closed_exception()if the_statusisstatus::shutting_down: f935a80.Because of this change, when this function throws (i.e. during shutdown), the previously truly
noexceptconstructor now causes an abort of the program.Move the call to outside of the
noexceptconstructor to prevent this race from terminating the program.Backports Required
Release Notes