Skip to content

Make parsetree expression attributes immutable #8685

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cknitt merged 2 commits into from
Sep 28, 2026
+2 −2
Merged

Make parsetree expression attributes immutable #8685

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e2675d
Make parsetree expression attributes immutable
cknitt Sep 27, 2026
cfd2c2a
Document immutable expression attributes
cknitt Sep 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@

#### :house: Internal

- Make expression attributes immutable in the current parsetree, now that editor refactors construct new expression nodes. https://github.com/rescript-lang/rescript/pull/8685
- Remove the unused `pat_record_label` alias from the current parsetree. https://github.com/rescript-lang/rescript/pull/8684
- Remove the unused `Ppat_open` and `Tpat_open` AST nodes, with current-AST and CMT format bumps. https://github.com/rescript-lang/rescript/pull/8682
- Represent ternary expressions with a dedicated parsetree node. https://github.com/rescript-lang/rescript/pull/8674
Expand Down
3 changes: 1 addition & 2 deletions compiler/ml/parsetree.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,8 +262,7 @@ and pattern_desc =
and expression = {
pexp_desc: expression_desc;
pexp_loc: Location.t;
(* Hack: made pexp_attributes mutable for use in analysis exe. Please do not use elsewhere! *)
mutable pexp_attributes: attributes; (* ... [@id1] [@id2] *)
pexp_attributes: attributes; (* ... [@id1] [@id2] *)
}

and expression_desc =
Expand Down
Loading