Skip to content

Make parsetree expression attributes immutable - #8685

Open
cknitt wants to merge 2 commits into
codex/pexp-bracesfrom
codex/immutable-pexp-attributes
Open

cknitt wants to merge 2 commits into
codex/pexp-bracesfrom
codex/immutable-pexp-attributes

Conversation

@cknitt

@cknitt cknitt commented Sep 27, 2026

Copy link
Copy Markdown
Member

Summary

Make pexp_attributes immutable in the current parsetree. The editor's “Add braces to function” action was its only in-place writer; the Pexp_braces change in #8678 now constructs a new expression instead.

The frozen parsetree0.ml stays unchanged for external PPX compatibility. This PR is stacked on #8678 and continues #8624.

Verification

  • make test
  • make test-analysis

@cknitt
cknitt marked this pull request as ready for review September 27, 2026 14:18
@cknitt
cknitt added this pull request to stack #8683 September 27, 2026 14:18
@pkg-pr-new

pkg-pr-new Bot commented Sep 27, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript@8685

@rescript/belt

npm i https://pkg.pr.new/@rescript/belt@8685

@rescript/darwin-arm64

npm i https://pkg.pr.new/@rescript/darwin-arm64@8685

@rescript/darwin-x64

npm i https://pkg.pr.new/@rescript/darwin-x64@8685

@rescript/linux-arm64

npm i https://pkg.pr.new/@rescript/linux-arm64@8685

@rescript/linux-x64

npm i https://pkg.pr.new/@rescript/linux-x64@8685

@rescript/runtime

npm i https://pkg.pr.new/@rescript/runtime@8685

@rescript/win32-x64

npm i https://pkg.pr.new/@rescript/win32-x64@8685

commit: cfd2c2a

@cknitt
cknitt force-pushed the codex/immutable-pexp-attributes branch 5 times, most recently from cc7bf86 to f244eaa Compare September 27, 2026 18:56
Signed-off-by: Christoph Knittel <ck@cca.io>
Signed-off-by: Christoph Knittel <ck@cca.io>
@cknitt
cknitt force-pushed the codex/immutable-pexp-attributes branch from f244eaa to cfd2c2a Compare September 27, 2026 20:02

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant