Conversation
cknitt
marked this pull request as ready for review
September 27, 2026 14:18
cknitt
added this pull request to stack #8683
September 27, 2026 14:18
rescript
@rescript/belt
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
cknitt
force-pushed
the
codex/immutable-pexp-attributes
branch
5 times, most recently
from
September 27, 2026 18:56
cc7bf86 to
f244eaa
Compare
Signed-off-by: Christoph Knittel <ck@cca.io>
Signed-off-by: Christoph Knittel <ck@cca.io>
cknitt
force-pushed
the
codex/immutable-pexp-attributes
branch
from
September 27, 2026 20:02
f244eaa to
cfd2c2a
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make
pexp_attributesimmutable in the current parsetree. The editor's “Add braces to function” action was its only in-place writer; thePexp_braceschange in #8678 now constructs a new expression instead.The frozen
parsetree0.mlstays unchanged for external PPX compatibility. This PR is stacked on #8678 and continues #8624.Verification
make testmake test-analysis