Repository navigation
Conversation
Documentation only. No application code changed since 2.1.2, so the APK is functionally identical and only versionCode and versionName differ. Published to repair the ZapStore listing, whose Install button was greyed out. The relay had rejected the kind 3063 asset event that carries the APK, because it requires a version_code tag on any asset with an android- platform and the publish action was not emitting one. The release event survived and pointed at an asset event the relay did not have, which left a listing with no APK behind the button. The rejection was invisible because the action awaited an array of promises rather than the promises themselves, so the run exited 0 having logged "published kind 3063". Both defects are fixed in zapstore-publish v1.0.2, which release.yml picks up through @v1. This also carries the listing icon from #87 into a published event, which had never happened before: zapstore.yaml had no icon field, and that fix landed after 2.1.2 was tagged. Verified against the built artifact rather than the source file, which is the check that catches a typo the version grep cannot: package: name='org.golder.sms2webhook' versionCode='7' versionName='2.1.3' platformBuildVersionName='16' ./gradlew check passes. The on-device smoke test in step 4 of the checklist is skipped: nothing touching the sync, uploads, permissions or WorkManager changed, so the only new input is the published listing.
🤖 Automated Code Review |
Owner
Author
|
Superseded rather than rebased. #88 merged after this was opened, so master now declares versionCode 7 / 2.2.0 and rebasing would move versionName backwards, labelling the main-screen redesign as 2.1.3. The repair this release existed for is a new publish, not a version rollback: release.yml pins rossigee/zapstore-publish@v1, so tagging 2.2.0 picks up the fixed v1.0.2 and re-emits the asset event with the version_code tag the relay requires. Its substance is folded into the 2.2.0 entry in #91, along with the note that this is the first release where the icon from #87 reaches a published event. |
rossigee
added a commit
that referenced
this pull request
Oct 6, 2026
PR #89 proposed a 2.1.3 release to repair the Zapstore listing, whose Install button was greyed out. It cannot ship as written: #88 has since merged and master already declares versionCode 7 / 2.2.0, so rebasing #89 would move versionName backwards and label the main-screen redesign as 2.1.3. The repair is a new publish, not a version rollback. release.yml pins rossigee/zapstore-publish@v1, so tagging 2.2.0 picks up the fixed v1.0.2 and re-emits the asset event with a version_code tag the relay accepts. Carries across the useful half of #89's entry: the listing repair, and the note that this is the first release where the icon from #87 reaches a published event. Drops its "documentation only" framing, which was true of 2.1.3 and is not of 2.2.0. Also brings the entry up to date for #90's documentation work and the 146 tests that now exist.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repairs the ZapStore listing: the Install button was greyed out because the relay had rejected the asset event carrying the APK.
What was wrong
Querying
relay.zapstore.devfor this app's kinds returned the app event and all three release events — and no kind 3063 asset event at all. Each release pointed at an asset id the relay did not have, so the listing existed with nothing behind the button.The relay requires it (
zapstore/relay/pkg/events/app_asset.go):The publish action never emitted
version_code. That is fixed in zapstore-publish v1.0.2, whichrelease.ymlpicks up through@v1, so no workflow change is needed here.The rejection was silent because the action awaited an array of promises instead of the promises themselves, so the run exited 0 having logged
published kind 3063. Also fixed in v1.0.2.This release exists to publish an asset event the relay accepts — nothing re-publishes a listing on its own.
Also in this release
The app icon from #87 reaches a published event for the first time.
zapstore.yamlhad noicon:field, so every listing so far showed a placeholder letter, and #87 landed after 2.1.2 was tagged.Version bump
versionCode6 → 7 andversionName2.1.2 → 2.1.3, in the same PR as the changelog entry, per steps 1 and 2 of the release checklist.Verified against the built artifact rather than the source file — the check that catches a typo the version grep cannot:
./gradlew checkpasses.Checklist steps not performed
masterfirst, so this needs a human merge beforev2.1.3is pushed.After merge
Then confirm in the
Publish to Zapstorestep, per step 7 — a green run does not prove anything published. This time the log should contain:and with the relay now awaited, a rejection would fail the step instead of passing quietly.