Repository navigation
Record the Zapstore listing repair in the 2.2.0 entry - #91
Merged
Merged
Conversation
PR #89 proposed a 2.1.3 release to repair the Zapstore listing, whose Install button was greyed out. It cannot ship as written: #88 has since merged and master already declares versionCode 7 / 2.2.0, so rebasing #89 would move versionName backwards and label the main-screen redesign as 2.1.3. The repair is a new publish, not a version rollback. release.yml pins rossigee/zapstore-publish@v1, so tagging 2.2.0 picks up the fixed v1.0.2 and re-emits the asset event with a version_code tag the relay accepts. Carries across the useful half of #89's entry: the listing repair, and the note that this is the first release where the icon from #87 reaches a published event. Drops its "documentation only" framing, which was true of 2.1.3 and is not of 2.2.0. Also brings the entry up to date for #90's documentation work and the 146 tests that now exist.
Closed
🤖 Automated Code Review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this replaces
PR #89 proposed 2.1.3 to repair the ZapStore listing. It cannot ship as written.
#88 merged after #89 was opened, and master now declares
versionCode 7/2.2.0.Rebasing #89 would resolve the collision in its favour and move
versionNamebackwards, labelling the main-screen redesign as 2.1.3 at the same
versionCode.So #89 is being closed and its substance folded in here.
Why the repair doesn't need its own version
The repair is a new publish, not a version rollback. The cause:
version_codetag on any asset event with anandroid-platform, and the publish action was not emitting one
listing with no APK behind the Install button
rather than the promises themselves, so the rejection surfaced as noise
Both are fixed in
zapstore-publishv1.0.2, andrelease.ymlpinsrossigee/zapstore-publish@v1— so tagging 2.2.0 picks it up and re-emits an assetevent the relay accepts.
What carried across
zapstore.yamlgained anicon:field after 2.1.2 was taggedWhat was corrected rather than copied
#89's entry was framed "Documentation only. No application code changed since
2.1.2." That was true of 2.1.3 and is false of 2.2.0, which redesigns the main screen
and changes what gets uploaded. Copying the framing would have been wrong in the one
file
zapstore.yamlreads for published release notes.Also brought up to date for work already merged: #90's webhook-contract documentation,
and the 146 tests that now exist rather than 143.
Documentation only, and
./gradlew checkpasses.