Remove unused rspec_junit_formatter dependency#260
Conversation
This was added for Jenkins CI reporting in the 0.6.0 release (2016) but was never wired up in Travis CI or GitHub Actions workflows. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Removes the rspec_junit_formatter development dependency from the gem specification, aiming to drop an unused CI/reporting dependency that is not configured in current workflows.
Changes:
- Removed
rspec_junit_formatterfromruby-plsql.gemspecdevelopment dependencies.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| s.add_development_dependency "rake", ">= 10.0" | ||
| s.add_development_dependency "rspec", "~> 3.1" | ||
| s.add_development_dependency "rspec_junit_formatter" | ||
| s.add_development_dependency "simplecov" | ||
| s.add_development_dependency "ruby-oci8", "~> 2.1" |
There was a problem hiding this comment.
Removing rspec_junit_formatter from the gemspec doesn’t fully remove the dependency from the repo: it’s still listed in the root Gemfile (line 4) and in multiple gemfiles/Gemfile.activerecord-* files. As-is, local development/CI that bundles via those Gemfiles will still install it, which conflicts with the PR description. Please remove those Gemfile entries (or explain/retain intentionally) so the dependency is actually eliminated.
|
Let's reave as it is. |
Summary
rspec_junit_formatterfrom development dependencies.rspecfile, spec config, or CI workflow references the junit formatter🤖 Generated with Claude Code