Skip to content

Remove unused rspec_junit_formatter dependency #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yahonda wants to merge 1 commit into from
Closed

Remove unused rspec_junit_formatter dependency #260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ruby-plsql.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ Gem::Specification.new do |s|

s.add_development_dependency "rake", ">= 10.0"
s.add_development_dependency "rspec", "~> 3.1"
s.add_development_dependency "rspec_junit_formatter"
s.add_development_dependency "simplecov"
s.add_development_dependency "ruby-oci8", "~> 2.1"
Comment on lines 22 to 25
Copy link

Copilot AI Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing rspec_junit_formatter from the gemspec doesn’t fully remove the dependency from the repo: it’s still listed in the root Gemfile (line 4) and in multiple gemfiles/Gemfile.activerecord-* files. As-is, local development/CI that bundles via those Gemfiles will still install it, which conflicts with the PR description. Please remove those Gemfile entries (or explain/retain intentionally) so the dependency is actually eliminated.

Copilot uses AI. Check for mistakes.
end