Fix mess() SpatVector and single-column data.frame bugs - #34
Open
jeffery-leirness wants to merge 3 commits into
Open
Fix mess() SpatVector and single-column data.frame bugs#34jeffery-leirness wants to merge 3 commits into
jeffery-leirness wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #33.
Developed with assistance from an AI coding assistant (Posit Assistant / Claude). All changes reviewed, tested, and verified by the PR author.
Changes in R/mess.R:
geomtype(p) → geomtype(v) in the SpatVector geometry check
extract(v, x) → extract(x, v, ID = FALSE) to fix argument order and suppress the ID column
v <- as.matrix(v) added after na.omit() to handle data frame output from extract()
.messi(x, v) → .messi(x[, 1], v[, 1]) in the single-column data.frame method
Changes in tests/testthat/test-mess.R:
New test file with 9 regression tests covering all four bug fixes