Repository navigation
Send old tickets to the new registration's balance - #2949
Merged
Merged
Conversation
maebeale
marked this pull request as ready for review
November 5, 2026 16:10
This was referenced Nov 5, 2026
maebeale
force-pushed
the
maebeale/transferred-registrant-payments
branch
from
November 5, 2026 17:32
9fee11b to
b04f6aa
Compare
maebeale
force-pushed
the
maebeale/old-ticket-reads-new-balance
branch
from
November 5, 2026 17:32
3168760 to
6e6eb63
Compare
maebeale
force-pushed
the
maebeale/transferred-registrant-payments
branch
from
November 5, 2026 18:02
b04f6aa to
823abaf
Compare
maebeale
force-pushed
the
maebeale/old-ticket-reads-new-balance
branch
from
November 5, 2026 18:02
0113563 to
92b3508
Compare
Base automatically changed from
maebeale/transferred-registrant-payments
to
main
November 5, 2026 19:03
Once a transferred registrant paid on the new registration, the old ticket still said "Make your payment" with a balance due, and its payment page has no Pay button. It was a dead end, and it told people who had paid that they still owed. Also seeds transfer scenarios, since reviewers had no data to try this with. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Let a balance carried into a free event be paid Someone who transferred into a free event with money still owed had no Pay button, so they stayed locked out of payment-gated callouts with no way to settle it. The ticket judged that from the new event's price, but the balance is priced at the original event. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Link the free-event balance seed to its PR Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Put each transfer notice sentence on its own line The notices ran together as one block, so registrants had to read through it to find where to pay and where their records stay. Short sentences on separate lines make each point easy to spot. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
maebeale
force-pushed
the
maebeale/old-ticket-reads-new-balance
branch
from
November 5, 2026 19:04
92b3508 to
639a276
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 suggested review level: 3 Read 📖 small read-path change on the old ticket plus a dev-only seed
Old tickets now show the balance on the new registration, because people who had already paid there were still told "Make your payment" on a page with no Pay button.
rake db:seed:transfersadds paid, intends-to-pay, and partial transfers.Worth a close look
Stacked on #2945
mainwhen Let transferred registrants pay their balance on the new registration #2945 merges.Features seed
UI Testing Checklist
rake db:seed:transfersruns twice without duplicates🤖 Generated with Claude Code