Skip to content

Remove the 4 failing tests from rustdoc-gui#152194

Open
JonathanBrouwer wants to merge 1 commit intorust-lang:mainfrom
JonathanBrouwer:fix-rustdoc-gui
Open

Remove the 4 failing tests from rustdoc-gui#152194
JonathanBrouwer wants to merge 1 commit intorust-lang:mainfrom
JonathanBrouwer:fix-rustdoc-gui

Conversation

@JonathanBrouwer
Copy link
Contributor

These are the 4 tests that @Bryntet got to fail locally
See #t-infra > CI failure because `tests/rustdoc-gui/search-filter.goml`

r? @ghost

@rustbot
Copy link
Collaborator

rustbot commented Feb 6, 2026

Some changes occurred in GUI tests.

cc @GuillaumeGomez

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Feb 6, 2026
@jieyouxu
Copy link
Member

jieyouxu commented Feb 6, 2026

Tracked in #152197. Given that a contributor said they can reproduce test failures of these 4 tests locally (#t-infra > CI failure because `tests/rustdoc-gui/search-filter.goml` @ 💬), I am going to r+ this to try to unblock the tree. Hopefully it at least reduces the likelihood down from "every PR is hitting these" to "occassionally".

@bors r+

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 6, 2026

📌 Commit bce8c00 has been approved by jieyouxu

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 6, 2026
jieyouxu added a commit to jieyouxu/rust that referenced this pull request Feb 6, 2026
…=jieyouxu

Remove the 4 failing tests from rustdoc-gui

These are the 4 tests that @Bryntet got to fail locally
See [#t-infra > CI failure because &rust-lang#96;tests/rustdoc-gui/search-filter.goml&rust-lang#96;](https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/CI.20failure.20because.20.60tests.2Frustdoc-gui.2Fsearch-filter.2Egoml.60/with/572271674)

r? @ghost
rust-bors bot pushed a commit that referenced this pull request Feb 6, 2026
Rollup of 4 pull requests

Successful merges:

 - #152174 (stdarch subtree update)
 - #151278 (Provide more context on trait bounds being unmet due to imperfect derive)
 - #151955 (escape symbol names in global asm)
 - #152194 (Remove the 4 failing tests from rustdoc-gui)

Failed merges:

 - #152191 (Convert to inline diagnostics in `rustc_hir_analysis`)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants