Always exhaustively match on typing mode#155047
Merged
rust-bors[bot] merged 5 commits intorust-lang:mainfrom Apr 10, 2026
Merged
Always exhaustively match on typing mode#155047rust-bors[bot] merged 5 commits intorust-lang:mainfrom
rust-bors[bot] merged 5 commits intorust-lang:mainfrom
Conversation
Collaborator
|
Some changes occurred in compiler/rustc_passes/src/check_attr.rs Some changes occurred to the CTFE machinery Some changes occurred to the CTFE / Miri interpreter cc @rust-lang/miri Some changes occurred in compiler/rustc_attr_parsing Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt Some changes occurred in compiler/rustc_hir/src/attrs Some changes occurred to constck cc @fee1-dead changes to the core type system cc @lcnr |
rustbot
added
A-attributes
jdonszelmann
force-pushed
the
lint-against-eq-typing-mode
branch
from
63485a1 to
ef0684a
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
jdonszelmann
force-pushed
the
lint-against-eq-typing-mode
branch
from
fcb4cae to
62dbaab
Compare
Collaborator
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
RalfJung
reviewed
Apr 9, 2026
This comment has been minimized.
This comment has been minimized.
jdonszelmann
force-pushed
the
lint-against-eq-typing-mode
branch
from
62dbaab to
791b38b
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
lcnr
reviewed
Apr 10, 2026
Comment on lines
+106
to
+109
| let typing_env = ty::TypingEnv::new( | ||
| cx.typing_env.param_env, | ||
| ty::TypingMode::analysis_in_body(cx.tcx, cx.body.source.def_id().expect_local()), | ||
| ); |
Contributor
There was a problem hiding this comment.
oh, this should use ty::TyingEnv::Borrowck or even PostBorrowckAnalysis with the new solver
compiler/rustc_trait_selection/src/traits/select/candidate_assembly.rs
Outdated
Show resolved
Hide resolved
jdonszelmann
force-pushed
the
lint-against-eq-typing-mode
branch
from
791b38b to
6b67e10
Compare
jdonszelmann
force-pushed
the
lint-against-eq-typing-mode
branch
from
6b67e10 to
19fd231
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
This comment has been minimized.
This comment has been minimized.
jdonszelmann
force-pushed
the
lint-against-eq-typing-mode
branch
from
19fd231 to
7760367
Compare
lcnr
reviewed
Apr 10, 2026
jdonszelmann
force-pushed
the
lint-against-eq-typing-mode
branch
from
7760367 to
679d16b
Compare
Contributor
Author
|
@bors r=lcnr |
Contributor
rust-bors
bot
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
jdonszelmann
force-pushed
the
lint-against-eq-typing-mode
branch
from
679d16b to
18d118a
Compare
rust-bors
bot
added
S-waiting-on-author
Contributor
|
This pull request was unapproved. |
Contributor
Author
|
@bors r=lcnr |
Contributor
rust-bors
bot
added
S-waiting-on-bors
rust-bors bot
pushed a commit
that referenced
this pull request
Apr 10, 2026
…uwer Rollup of 8 pull requests Successful merges: - #155047 (Always exhaustively match on typing mode) - #155080 (Simplify `try_load_from_disk_fn`.) - #152384 (Restrict EII declarations to functions at lowering time) - #153796 (Fix ICE when combining #[eii] with #[core::contracts::ensures]) - #154369 (Fix `pattern_from_macro_note` for bit-or expr) - #155027 ( Rename some more of our internal `#[rustc_*]` TEST attributes) - #155031 (delegation: fix unelided lifetime ICE, refactoring of GenericArgPosition) - #155040 (Fix code block whitespace handling in Markdown)
rust-timer
added a commit
that referenced
this pull request
Apr 10, 2026
Rollup merge of #155047 - jdonszelmann:lint-against-eq-typing-mode, r=lcnr Always exhaustively match on typing mode r? @lcnr Unimplements Eq/PartialEq for TypingMode, adds TypingModeEqWrapper for the few cases where we need it (mainly in the query system), and adds a new rustc internal lint to detect cases where we non-exhaustively match on typing mode.
github-actions bot
pushed a commit
to rust-lang/rustc-dev-guide
that referenced
this pull request
Apr 13, 2026
…uwer Rollup of 8 pull requests Successful merges: - rust-lang/rust#155047 (Always exhaustively match on typing mode) - rust-lang/rust#155080 (Simplify `try_load_from_disk_fn`.) - rust-lang/rust#152384 (Restrict EII declarations to functions at lowering time) - rust-lang/rust#153796 (Fix ICE when combining #[eii] with #[core::contracts::ensures]) - rust-lang/rust#154369 (Fix `pattern_from_macro_note` for bit-or expr) - rust-lang/rust#155027 ( Rename some more of our internal `#[rustc_*]` TEST attributes) - rust-lang/rust#155031 (delegation: fix unelided lifetime ICE, refactoring of GenericArgPosition) - rust-lang/rust#155040 (Fix code block whitespace handling in Markdown)
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Apr 14, 2026
…ly-let-else, r=JonathanBrouwer `#[rustc_must_match_exhaustively]` detect let else Extension of rust-lang#155047, I forgor to lint on let-else :3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
View all comments
r? @lcnr
Unimplements Eq/PartialEq for TypingMode, adds TypingModeEqWrapper for the few cases where we need it (mainly in the query system), and adds a new rustc internal lint to detect cases where we non-exhaustively match on typing mode.