Insert alignment checks for pointer dereferences when debug assertions are enabled#98112
Merged
bors merged 8 commits intorust-lang:masterfrom Mar 31, 2023
Merged
Insert alignment checks for pointer dereferences when debug assertions are enabled#98112bors merged 8 commits intorust-lang:masterfrom
bors merged 8 commits intorust-lang:masterfrom
Conversation
rustbot
added
T-compiler
saethlin
force-pushed
the
mir-alignment-checks
branch
from
f6d745b to
b8965f5
Compare
This comment has been minimized.
This comment has been minimized.
saethlin
force-pushed
the
mir-alignment-checks
branch
from
b8965f5 to
9f36630
Compare
This comment has been minimized.
This comment has been minimized.
Collaborator
|
☔ The latest upstream changes (presumably #98649) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
the
S-waiting-on-author
saethlin
force-pushed
the
mir-alignment-checks
branch
from
9f36630 to
caf7082
Compare
Collaborator
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt This PR changes MIR |
Member
Author
|
Oh heck I did not need everyone to be summoned like this |
This comment has been minimized.
This comment has been minimized.
Collaborator
|
☔ The latest upstream changes (presumably #98206) made this pull request unmergeable. Please resolve the merge conflicts. |
saethlin
force-pushed
the
mir-alignment-checks
branch
from
caf7082 to
54eb093
Compare
This comment has been minimized.
This comment has been minimized.
Collaborator
|
☔ The latest upstream changes (presumably #101858) made this pull request unmergeable. Please resolve the merge conflicts. |
saethlin
force-pushed
the
mir-alignment-checks
branch
from
54eb093 to
a878c4a
Compare
This comment has been minimized.
This comment has been minimized.
saethlin
force-pushed
the
mir-alignment-checks
branch
from
a878c4a to
6f8274c
Compare
This comment has been minimized.
This comment has been minimized.
saethlin
force-pushed
the
mir-alignment-checks
branch
2 times, most recently
from
f700f3b to
be80cb2
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
|
@bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
rustbot
added
the
S-waiting-on-perf
Collaborator
|
⌛ Trying commit be80cb2b565657734acfd69f75331a1d8200d517 with merge 64fdee20bfba2e2033f0df0374119c0461ae4d2e... |
Collaborator
|
☀️ Try build successful - checks-actions |
Merged
This was referenced May 11, 2023
This was referenced Jun 4, 2023
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #54915
MirPatch, but I can't figure out how to insert a new basic block with a new terminator in the middle of an existing basic block, usingMirPatch. (if nobody else backs up this point I'm checking this as "not actually a good idea" because the code looks pretty clean to me after rearranging it a bit)CastKind::PointerExposeAddressis definitely wrong, we don't want to expose. Calling a function to get the pointer address seems quite excessive.I'll see if I can add a newCastKind.CastKind::Transmuteto the rescue!r? @oli-obk