Start daemon connection before first-run onboarding - #579
Merged
Merged
Conversation
Part of #556. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
coneilen
force-pushed
the
coneilen-microsoft-first-run-daemon-ordering
branch
from
October 2, 2026 01:37
26699d0 to
6556d99
Compare
3 of 5 tasks
coneilen
added this pull request to stack #581
October 2, 2026 02:00
This was referenced Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #556. Start the daemon client connection independently before the modal first-run onboarding sequence, without changing onboarding UI implementation or closing the issue.
Changes
DaemonClient.connect()before a genuine first-run modal enters its message loop.Test plan
RED: & $env:GRAPHCODE_ZIG0152 test src\App.zig src\AccessibilityProvider.cpp src\FilePicker.c $wing -DUNICODE -D_UNICODE -target x86_64-windows-msvc -lc -luser32 -lgdi32 -lgdiplus -lmsimg32 -lopengl32 -lkernel32 -limm32 -lole32 -loleaut32 -luiautomationcore -lshell32 -ladvapi32 -lwinhttp "-I$include" $vt --test-filter "first-run startup schedules daemon connection before the modal returns" -> expected .connection_scheduled, found .modal_entered; 0 passed, 1 failed
GREEN: & $env:GRAPHCODE_ZIG0152 test src\App.zig src\AccessibilityProvider.cpp src\FilePicker.c $wing -DUNICODE -D_UNICODE -target x86_64-windows-msvc -lc -luser32 -lgdi32 -lgdiplus -lmsimg32 -lopengl32 -lkernel32 -limm32 -lole32 -loleaut32 -luiautomationcore -lshell32 -ladvapi32 -lwinhttp "-I$include" $vt --test-filter "first-run startup schedules daemon connection before the modal returns" -> 1/1 passed
REGRESSION: & $env:GRAPHCODE_ZIG0152 test src\App.zig src\AccessibilityProvider.cpp src\FilePicker.c $wing -DUNICODE -D_UNICODE -target x86_64-windows-msvc -lc -luser32 -lgdi32 -lgdiplus -lmsimg32 -lopengl32 -lkernel32 -limm32 -lole32 -loleaut32 -luiautomationcore -lshell32 -ladvapi32 -lwinhttp "-I$include" $vt -> 731/731 passed on rerun; initial run was 730/731 because an unrelated foreground-sensitive overview test failed, then passed 1/1 in isolation
Native package install, first-launch onboarding, keyboard operation, and UI Automation were not run. This PR does not claim those acceptance criteria.
Remaining layer 2 acceptance criteria: expose named keyboard-operable UIA pages and actions with deterministic focus, preserve modal foreground/ownership/teardown, and exercise package install through first launch, onboarding, and connected Welcome using native keyboard and UIA.
Checklist
git commit -s) per the DCOmake test)make check)