Repository navigation
Require windows-spikes validation for token and contract changes - #793
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: Colin Neilens <coneilen@microsoft.com>
2 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Close a gap in the orchestration plan's per-PR gate. A wave-1 PR added a design token, passed the full windows-shell unit run, and then failed exact-head CI. The failure was in the palette-parity contract, which runs only under
validate.ps1 -Task windows-spikes.Changes
investigation/windows-parity-orchestration-plan.md: the per-PR full-validation step now also requires-Task windows-spikeswhenDesignTokens.zig, palette, font or contract files change.Test plan
RED: exact-head CI on PR #789 (e6fcc49), Windows port validation run 38525363547 -> PaletteParity.Tests.ps1 failed: parsed Windows token has no mapping or documented exception: loop_minimap_surface, after the lane's full -ShellPart unit run passed 55/55 sections
GREEN: Select-String investigation\windows-parity-orchestration-plan.md -Pattern 'windows-spikes' -> the per-PR gate names it for token/palette/contract changes
REGRESSION: git diff --check -> clean; git ls-files --eol -> CRLF preserved; bash Tools/ci/tests/classify-changes.test.sh -> 59 passed, 0 failed
Documentation-only change: no product code, so the Windows suites and macOS
make test/make checkwere not run.Checklist
git commit -s) per the DCOmake test)make check)