Repository navigation
Run the native UIA provider tests in windows-shell unit validation - #802
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Signed-off-by: coneilen <coneilen@users.noreply.github.com>
This was referenced Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tools/windows/Tests/AccessibilityProvider.Native.Tests.ps1, the native C++ UIA provider regression suite, was orphaned: no task invalidate.ps1and no workflow invoked it. So native accessibility provider changes (such as lane D2'sworkspace-restart-sessionmapping for #774) could not get exact-head CI evidence. Lane D2 found this on 2026-10-14.This PR runs the suite once per
windows-shellunit run, on shard 0, so it executes in exact-head CI.Changes
Tools/windows/validate.ps1: after the shardedWindowsShell.Tests.ps1contract in the unit part, shard 0 runsAccessibilityProvider.Native.Tests.ps1throughInvoke-Native, so a non-zero exit fails the task. The suite isn't sharded, so it runs exactly once across the 3-shard CI matrix and in local unsharded runs.Test plan
RED: Select-String origin/main Tools/windows/validate.ps1 for AccessibilityProvider.Native.Tests.ps1 -> 0 invocations; the native suite never ran in CI
GREEN: Select-String edited validate.ps1 -> 1 invocation (shard 0); local native build of the suite on main via MSVC cl -> Native accessibility provider: 176 checks, 0 failures
REGRESSION: pwsh Tools/windows/Tests/ValidationRunner.Tests.ps1 -> ValidationRunner.Tests.ps1: PASS (384 multi-project contracts, 50 positive, 334 negative); git diff --check -> clean; bash Tools/ci/tests/classify-changes.test.sh -> 59 passed, 0 failed
Local environment caveat.
vcvars64.batexits 1 because the optionalext\ConnectionManagerExe.batcan't find the VC Linux component, so the script'scall vcvars && clchain stops locally.clcommand chained with&.windows-2022runner is the authoritative check: the exact-head shard-0 job must show theNative accessibility provider: N checks, 0 failuresline with N greater than 0.make testandmake checkwere not run, because no Swift was touched.Checklist
git commit -s) per the DCOmake test)make check)