OKD-380: Add missing namespace to image trigger annotations

[pskrbasu]

Problem

Deploying CakePHP+MySQL from the OKD 4.22 Software Catalog fails with:

spec.containers[0].image: Invalid value: " ": must not have leading or trailing whitespace

Reported in okd-project/okd#2337

Root Cause

When templates were migrated from DeploymentConfig to Deployment, the image.openshift.io/triggers annotation on the MySQL database Deployment dropped the namespace field from the ImageStreamTag reference. Without it, the image trigger controller defaults to the Deployment's own namespace instead of openshift, so it can't find the ImageStream and the container image is never resolved.

Fix

Add "namespace":"${NAMESPACE}" to the trigger annotation's from object on the database Deployment in both cakephp-mysql and cakephp-mysql-persistent templates. The NAMESPACE parameter already exists in both templates with a default value of "openshift".

Impact

These template files are the upstream source for openshift/library (via make import) and ultimately openshift/cluster-samples-operator. An immediate fix was applied directly to the operator in openshift/cluster-samples-operator#701. This upstream fix ensures the bug doesn't recur on the next sync.

[coderabbitai]

Warning

Review limit reached

@pskrbasu, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 59 minutes and 40 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 399b9ddb-1fe9-4bad-a4f5-5ecd1fbad41d

📥 Commits

Reviewing files that changed from the base of the PR and between ad1d88a and a399ce7.

📒 Files selected for processing (2)

• openshift/templates/cakephp-mysql-persistent.json
• openshift/templates/cakephp-mysql.json

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[phracek]

[test]