Repository navigation
fix(release): build no candidate while changesets wait for the version PR - #153
Merged
Merged
Conversation
…n PR Candidate 38829436447 was versioned 0.1.0-alpha.16 but contained the screenshot and Jev vision changes, whose changesets the version PR had not applied yet. Publishing it would have shipped a breaking change under a changelog that omits it. needs-candidate now skips the build while .changeset/ holds changesets that pre.json does not list as applied. Amp-Thread-ID: https://ampcode.com/threads/T-09962b75-0e4a-44c9-b9e2-bea9aff8ac44 Co-authored-by: Ignacio Gutierrez <nachojgutierrez@gmail.com>
![codescene-access[bot]](https://avatars.githubusercontent.com/in/3755875?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Candidate run 38829436447 was versioned
0.1.0-alpha.16, but it contained the screenshot checks (#148) and the Jev vision fallback (#151), whose changesets the version PR had not applied yet. Publishing it would have shipped a breaking vision change under the alpha.16 changelog, which omits it.needs-candidate.mjsnow skips the candidate build while.changeset/holds changesets thatpre.jsondoesn't list as applied, and prints which ones. Once the version PR merges, the next CI run onmainbuilds the candidate as before.Checked locally:
node --test scripts/release/*.test.mjs: 7 pass.needs-candidate.mjson currentmain: "Build candidate for unpublished 0.1.0-alpha.17"..changeset/from 45a1ec0: "No candidate … Not yet versioned: jev-vision-fallback, screenshot-checks".Merge after alpha.17 is published. Merging earlier puts a newer commit on
main, which replaces the alpha.17 candidate that's in UAT.https://ampcode.com/threads/T-09962b75-0e4a-44c9-b9e2-bea9aff8ac44