Skip to content

fix(session): render completed agent rows below the done toggle - #557

Merged
astyfx merged 1 commit into
mainfrom
fix/task-collapsible-under
Sep 18, 2026
Merged

astyfx merged 1 commit into
mainfrom
fix/task-collapsible-under

Conversation

@astyfx

@astyfx astyfx commented Sep 18, 2026

Copy link
Copy Markdown
Member

Summary

In the Task Activity work graph, completed agent rows rendered above the active rows, so expanding the "N done" toggle revealed them at the top of the section instead of directly beneath the toggle. This splits active and completed rows into separate render regions so the expanded completed rows appear immediately below the toggle.

Changes

Fixes

  • session: render completed agent rows below the "N done" toggle in the Task Activity work graph, instead of above the active rows

Refactors / Chores

  • dev: extend the agent-tree ADS regression preview fixture with a completed node so the expand ordering is visible in preview

Test Evidence

  • bun test tests/work-graph-tree-render.test.tsx — 14 pass, 0 fail (adds a regression assertion that Live audit precedes the 1 done toggle, which precedes Finished audit, and that the completed rows region is hidden while collapsed)
  • bun run typecheck — passes
  • bun run check:design-system — passes (ratchet: 0 files contain utility syntax)
  • Manual: verified expand position in Light and Dark themes via Lens

Notes

  • Scope is limited to the work graph completed-row ordering; no theme tokens, provider/IPC contracts, or dependencies were touched.
  • bun run check:licenses fails locally due to a missing license-checker module in this worktree's node_modules (pre-existing environment issue, unrelated to this diff).

Completed agent rows in the Task Activity work graph were rendered above the active rows, so expanding the "N done" toggle revealed them at the top instead of directly beneath the toggle. Split active and completed rows into separate render regions so expanding the toggle shows completed rows immediately below it.
@astyfx
astyfx requested a review from a team as a code owner September 18, 2026 04:08
@astyfx
astyfx requested review from dodonmountain and heath-s and removed request for a team September 18, 2026 04:08
@astyfx
astyfx enabled auto-merge (squash) September 18, 2026 04:08
@upwind-code-us

upwind-code-us Bot commented Sep 18, 2026

Copy link
Copy Markdown

Upwind Upwind Code Scan - ⚠️ Warn

7 newly introduced vulnerabilities · 0 resolved · 64 total in this PR vs main

Total breakdown: 🔶 13 High | 🟡 48 Medium | 🟢 3 Low


🔶 High · 7 findings
CVE Package Version Fix
CVE-2026-18446 fast-uri 3.1.0 3.1.5
CVE-2026-13676 fast-uri 3.1.0 3.1.3
CVE-2026-6322 fast-uri 3.1.0 3.1.2
CVE-2026-76172 fast-uri 3.1.0 3.1.6
CVE-2026-16221 fast-uri 3.1.0 3.1.4
CVE-2026-75975 fast-uri 3.1.0 3.1.6
CVE-2026-6321 fast-uri 3.1.0 3.1.1

View full analysis in Upwind Console

Scan completed in 11s

Scan history (1 scan)
Commit Scanned at New Resolved Net
0d6f504 < 2026-09-18 04:08 UTC +7 0 +7

Last scanned: 0d6f504 · 2026-09-18 04:08 UTC

@upwind-code-us

upwind-code-us Bot commented Sep 18, 2026

Copy link
Copy Markdown

Upwind Upwind IaC Scan - ✅ Passed

0 newly introduced misconfigurations · 0 resolved · 0 total in this PR vs main

View full analysis in Upwind Console →

Scan completed in 4s

Scan history (1 scan)
Commit Scanned at New Resolved Net
0d6f504 < 2026-09-18 04:08 UTC 0 0 0

Last scanned: 0d6f504 · 2026-09-18 04:08 UTC

@heath-s heath-s left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@astyfx
astyfx merged commit 8db6cdf into main Sep 18, 2026
6 checks passed
@astyfx
astyfx deleted the fix/task-collapsible-under branch September 18, 2026 04:17
@astyfx astyfx mentioned this pull request Sep 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants