Open
Conversation
Author
|
@shellscape This PR addresses #42 (comment) for Mocha v8 and forward support. Per another comment on that PR would it be possible to get this merged and cut into a release? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains:
Breaking Changes?
Mocha v7 deprecates
useColorsin favor ofcolor, and Mocha v8 and onwards don't supportuseColors. That means this fix of #42 (comment) will work with Mocha v7 and forward, but not Mocha v6 and before.Please Describe Your Changes
Addresses #42 (comment) to fix the updated mocha option from
colors(wrong) tocolor.This adds a
peerDependenciesentry inpackage.jsonfor"mocha": ">= 7.0.0"to represent the requirement of amochaversion that supports thecoloroption.