Skip to content

New Crowdin updates#2355

Open
myieye wants to merge 16 commits into
developfrom
l10n_develop
Open

New Crowdin updates#2355
myieye wants to merge 16 commits into
developfrom
l10n_develop

Conversation

@myieye

@myieye myieye commented Jun 13, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions github-actions Bot added the 💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related label Jun 13, 2026
@coderabbitai

coderabbitai Bot commented Jun 13, 2026

Copy link
Copy Markdown

Review Change Stack

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 804e2cb2-5749-45af-80df-a75051828299

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

Walkthrough

This PR adds localized translations for four new UI error messages across eight supported languages (English, Spanish, French, Indonesian, Korean, Malay, Swahili, and Vietnamese). The strings handle browse view failures, generic error states, task view failures, and retry actions, with updated source file references and PO metadata timestamps.

Changes

UI Error Message Translations

Layer / File(s) Summary
English baseline error messages
frontend/viewer/src/locales/en.po
Establishes source text for "Browse view failed", "Something went wrong", "Task view failed", and "Try again" error messages with ViewErrorBoundary reference.
European language translations
frontend/viewer/src/locales/es.po, frontend/viewer/src/locales/fr.po
Adds Spanish and French translations for all four error messages with updated PO-Revision-Date metadata and ViewErrorBoundary component references.
Asian and other language translations
frontend/viewer/src/locales/id.po, frontend/viewer/src/locales/ko.po, frontend/viewer/src/locales/ms.po, frontend/viewer/src/locales/sw.po, frontend/viewer/src/locales/vi.po
Adds Indonesian, Korean, Malay, Swahili, and Vietnamese translations for all error messages. Vietnamese also corrects plural form grammar ("các thay đổi") in an existing entry.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

💻 FW Lite

Suggested reviewers

  • rmunn

Poem

🐰 Eight languages now speak of errors clear,
When browse views and tasks disappear,
"Try again!" the messages softly say,
As ViewErrorBoundary lights the way. ✨

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'New Crowdin updates' is vague and generic, using non-descriptive terms that don't convey meaningful information about the changeset despite relating to it. Consider a more specific title like 'Add error message translations for UI view failures' or 'Update locale files with new error boundary strings'.
Description check ❓ Inconclusive No description was provided by the author, making it impossible to assess relatedness to the changeset. Add a description explaining the purpose of the Crowdin updates, such as which error messages were added and which views they affect.
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch l10n_develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@frontend/viewer/src/locales/ms.po`:
- Around line 1744-1747: The Malay translation for the msgid "Something went
wrong" in the gettext entry is awkward; update the msgstr for that msgid (the
entry with msgid "Something went wrong" used by ViewErrorBoundary) to a more
natural Malay phrase such as "Maaf, sesuatu telah berlaku." so the generic error
message reads idiomatically.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 97fe7eeb-e593-4cc4-8ada-d90bf07ca304

📥 Commits

Reviewing files that changed from the base of the PR and between 248ea03 and 28ddd53.

📒 Files selected for processing (8)
  • frontend/viewer/src/locales/en.po
  • frontend/viewer/src/locales/es.po
  • frontend/viewer/src/locales/fr.po
  • frontend/viewer/src/locales/id.po
  • frontend/viewer/src/locales/ko.po
  • frontend/viewer/src/locales/ms.po
  • frontend/viewer/src/locales/sw.po
  • frontend/viewer/src/locales/vi.po

Comment on lines +1744 to +1747
#: src/lib/layout/ViewErrorBoundary.svelte
msgid "Something went wrong"
msgstr "Sesuatu telah berlaku dengan salah"

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Refine Malay phrasing for the generic error message.

The current msgstr for “Something went wrong” reads unnaturally in Malay and can confuse users. A more idiomatic phrasing would improve clarity.

Suggested wording update
 msgid "Something went wrong"
-msgstr "Sesuatu telah berlaku dengan salah"
+msgstr "Sesuatu tidak kena"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
#: src/lib/layout/ViewErrorBoundary.svelte
msgid "Something went wrong"
msgstr "Sesuatu telah berlaku dengan salah"
#: src/lib/layout/ViewErrorBoundary.svelte
msgid "Something went wrong"
msgstr "Sesuatu tidak kena"
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@frontend/viewer/src/locales/ms.po` around lines 1744 - 1747, The Malay
translation for the msgid "Something went wrong" in the gettext entry is
awkward; update the msgstr for that msgid (the entry with msgid "Something went
wrong" used by ViewErrorBoundary) to a more natural Malay phrase such as "Maaf,
sesuatu telah berlaku." so the generic error message reads idiomatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant