Skip to content

fix(logs): keep checked trace content at every depth and label live projection warnings - #9692

Merged
waleedlatif1 merged 1 commit into
stagingfrom
improvement/release-review-1104
Nov 5, 2026
Merged

waleedlatif1 merged 1 commit into
stagingfrom
improvement/release-review-1104

Conversation

@waleedlatif1

@waleedlatif1 waleedlatif1 commented Nov 5, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Keep checked trace content at every depth when the projection budget runs out. Stored traces have one workflow-execution root, so retention that only worked per top-level span withheld the whole trace. Each span's own content still passes the whole-trace check before its children are walked; the span that crosses the budget and every span after it fall back to structure, and any failure other than the budget still withholds the whole trace
  • Budget warnings count spans across the tree from what was returned, so a rooted trace no longer reports retainedSpanCount: 0
  • Live display projections (display content, terminal block logs, child spans for a live viewer) said phase: 'write' because the label was inferred from large-value writes being enabled; they now pass phase: 'live'. Without the option the label is unchanged (write, or read when large-value writes are disabled), and storage behavior is unchanged
  • Supersedes fix(logs): keep checked trace content at every depth when the projection budget runs out #9697 (its projection change, scoped to lib/logs/execution)

Type of Change

  • Bug fix

Testing

  • trace-secret-projection, trace-store, logging-session Vitest: 131 passing
  • The rooted-trace test fails when children go back to the per-top-level loop; the live-phase test fails when the block-log path drops 'live'
  • Biome on changed files; CI runs type-check, audits, and the full suite

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing (new tests pass the test-audit authoring gate)
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated
docs Skipped Skipped Nov 5, 2026 2:23am UTC

Request Review

@greptile-apps

greptile-apps Bot commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

Keeps checked trace content at every depth when the shared content budget runs out.

  • Trace trees keep sanitized content checked before a budget cutoff at any depth.
  • Live trace display warnings now say which phase they belong to.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Project a span's own content] --> B[Check its content]
  B -->|Pass| C[Walk children]
  C --> A
  B -->|Content budget exhausted| D[Keep checked ancestors and earlier spans]
  D --> E[Strip content from this span and later spans]
  B -->|Other error| F[Strip content from the whole trace]
Loading

Reviews (4) · Last reviewed commit: "fix(logs): keep checked trace content at..." · Reviewed by Greptile

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 4 files

Reply with feedback, questions, or to request a fix.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 force-pushed the improvement/release-review-1104 branch from cb50228 to 1f06863 Compare November 5, 2026 02:13
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 force-pushed the improvement/release-review-1104 branch from 1f06863 to 260eded Compare November 5, 2026 02:20
@waleedlatif1 waleedlatif1 changed the title fix(logs): label live display projection warnings and tighten the sources dialog test fix(logs): keep checked trace content at every depth and label live projection warnings Nov 5, 2026
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 17 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 force-pushed the improvement/release-review-1104 branch from 260eded to 056c632 Compare November 5, 2026 02:23
@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@greptile

@waleedlatif1

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@waleedlatif1 I have started the AI code review. It will take a few minutes to complete.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 4 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Turn on auto-fix | Re-trigger cubic

@waleedlatif1
waleedlatif1 merged commit 5cda510 into staging Nov 5, 2026
79 of 80 checks passed
@waleedlatif1
waleedlatif1 deleted the improvement/release-review-1104 branch November 5, 2026 02:30

This branch was previously deployed

1 inactive deployment
Preview — 056c6325 Deployed Nov 5, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant