Repository navigation
fix(logs): keep checked trace content at every depth and label live projection warnings - #9692
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryKeeps checked trace content at every depth when the shared content budget runs out.
|
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply with feedback, questions, or to request a fix.
Turn on auto-fix | Re-trigger cubic
cb50228 to
1f06863
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
1f06863 to
260eded
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
…rojection warnings
260eded to
056c632
Compare
|
@cubic-dev-ai review this PR |
@waleedlatif1 I have started the AI code review. It will take a few minutes to complete. |
Summary
workflow-executionroot, so retention that only worked per top-level span withheld the whole trace. Each span's own content still passes the whole-trace check before its children are walked; the span that crosses the budget and every span after it fall back to structure, and any failure other than the budget still withholds the whole traceretainedSpanCount: 0phase: 'write'because the label was inferred from large-value writes being enabled; they now passphase: 'live'. Without the option the label is unchanged (write, orreadwhen large-value writes are disabled), and storage behavior is unchangedlib/logs/execution)Type of Change
Testing
trace-secret-projection,trace-store,logging-sessionVitest: 131 passing'live'Checklist
test-auditauthoring gate)